Tom and I tried running the Protoc code in an environment that didn’t have

unzip

installed, which resulted in downloading the tool to fail because in

core/util_rules/archive.py

, we expect for

unzip

to be discoverable on

/usr/bin:/bin:/usr/local/bin

. We also expect for

mkdir

and

tar

to both exist on those paths, along with

/bin/bash

existing. Is it reasonable to expect for

unzip

and

tar

to be installed, or should we rewrite this code to not run a

Process

? We used to do tar extraction in Rust for some JVM-related code.

can we just run Pants Python code in remote execution and use the built-in Python modules?

I think Twitter found that Python’s modules were much slower and/or less concurrent than they wanted

unzip in the remote image is fine

Cool. Agreed it should be documented that you need it

although I’d rather not rely on PATH

We could use the BinaryPaths mechanism to discover where the binary is installed. That didn’t exist when Benjy wrote this code a few months ago

let’s discuss tomorrow. I’d be fine with it passing “unzip” but not passing in a PATH