witty-crayon-22786
09/21/2020, 7:01 PMOptionsBootstrapper
param. there will be two commits: one that makes the OB unused, and then another that removes it everywhere.hundreds-father-404
09/21/2020, 7:02 PMwitty-crayon-22786
09/21/2020, 7:08 PMhundreds-father-404
09/21/2020, 9:36 PMtyping
. He isn’t back till Thursday, and hoping to land before then)witty-crayon-22786
09/21/2020, 9:36 PMhundreds-father-404
09/21/2020, 9:40 PMwitty-crayon-22786
09/21/2020, 9:56 PMhundreds-father-404
09/21/2020, 9:59 PMset_session_value
, but better is to make that private, and have set_options(args=, env=)
witty-crayon-22786
09/21/2020, 10:00 PMhundreds-father-404
09/21/2020, 10:01 PMwitty-crayon-22786
09/21/2020, 10:02 PMhundreds-father-404
09/21/2020, 10:02 PMwitty-crayon-22786
09/21/2020, 10:04 PM@_uncacheable_rule
seems close to graduating to an actual API.hundreds-father-404
09/21/2020, 10:05 PMwitty-crayon-22786
09/22/2020, 11:25 PMTODO: Once the OptionsBootstrapper has been removed from all relevant QueryRules
tomorrow morning and landed it now?hundreds-father-404
09/22/2020, 11:40 PMengine/internals
change is important too. It’s not a huge deal though to fix tomorrow, as there aren’t many imports of SessionValues
should you then pop this value from the inputs?
witty-crayon-22786
09/22/2020, 11:41 PMhundreds-father-404
09/22/2020, 11:42 PMwitty-crayon-22786
09/22/2020, 11:42 PMhundreds-father-404
09/22/2020, 11:43 PMwitty-crayon-22786
09/22/2020, 11:45 PM