See <https://github.com/pantsbuild/pants/issues/10...
# developmenth
hundreds-father-404
10/02/2020, 10:08 PMSee https://github.com/pantsbuild/pants/issues/10888#issuecomment-702979433 for a Target API limiation I’d love feedback on.
(Feel free to discuss in the thread or on GH)
a
aloof-angle-91616
10/02/2020, 10:09 PMfirst off: i would love to see this exact text in an issue if you haven't done so already so we don't lose it. will respond further after reading
👍 1
h
hundreds-father-404
10/02/2020, 10:10 PMI can move it to https://github.com/pantsbuild/pants/issues/10888, which is the original issue about the dependencies field
a
aloof-angle-91616
10/02/2020, 10:11 PMit seems like you've definitely identified a general problem, so i would recommend editing the OP to reflect this more general case instead of posting a comment
aloof-angle-91616
10/02/2020, 10:12 PMoh ok that works
👍 1
w
witty-crayon-22786
10/02/2020, 10:25 PMcommented, thanks!
witty-crayon-22786
10/02/2020, 10:28 PM...and then edited twice, sorry. done now.
witty-crayon-22786
10/02/2020, 10:33 PMgoing to step away for a bit, but i’m totally fine with a non-ideal solution for now, as we have time before we really need to stabilize the plugin API
a
aloof-angle-91616
10/03/2020, 12:49 PMi think there's a lot of value in the comment i posted, but it's somewhat long, and i recognize that's difficult to read. so i moved up the "merge sources fields automatically" idea to the very top (a direct response to the issue), and the rest are just fun sidequests for now: https://github.com/pantsbuild/pants/issues/10888#issuecomment-703002810
aloof-angle-91616
10/03/2020, 12:51 PMi was super interested in the
IntransitiveDependenciesaloof-angle-91616
10/03/2020, 12:53 PMplease lmk if that comment was constructive or could be improved. i think that i could make it shorter, but i did want to describe what currently seems possible to improve about the subclassing and e.g.
compute_raw_value()