https://pantsbuild.org/ logo
#development
Title
# development
f

fast-nail-55400

10/15/2020, 12:02 AM
is
pants.reporting.json_reporting.JsonReporter
still relevant?
h

hundreds-father-404

10/15/2020, 12:03 AM
I think we still use it for some things? Asher and Greg have the best handle on this.
h

hundreds-breakfast-49010

10/15/2020, 12:10 AM
that feels like code that pertained to the v1 reporting infrastructure, but I am not 100% sure there is nothing in pants today that relies on it
f

fast-nail-55400

10/15/2020, 12:19 AM
context: was wondering if I had to update that code for adding counters to work units
sounds like no?
h

hundreds-father-404

10/15/2020, 12:25 AM
Honestly, I’m not sure, but I don’t think so. @polite-garden-50641 I think I wanted to delete the JSON reporter code in the past but you explained it’s still partially used?
p

polite-garden-50641

10/15/2020, 12:28 AM
no. it is no longer used/relevant, the work units you see passed thru it are not the ones you are looking for. those are v1 engine work units. the v2 work units stuff is implemented in rust.
💯 1
f

fast-nail-55400

10/15/2020, 12:28 AM
ack. which is sent via
handle_workunits
on registered Subsystems, got it
👍 1
p

polite-garden-50641

10/15/2020, 12:31 AM
those things can probably be removed from run tracker. we still use some things from it, but mostly around
run_information()
, ,
cumulative_timings
,
pantsd_stats
,
v2_goals_rule_names
get_options_to_record()
h

hundreds-breakfast-49010

10/15/2020, 12:36 AM
we should delete the json reporter code if we are sure that nothing depends on it
2
👍 1
f

fast-nail-55400

10/15/2020, 12:49 AM
relatedly, I have a Subsystem that trivially implements Subsystem with handle_workunits but trying to invoke Pants with it results in:
Copy code
17:45:43.74 [ERROR] expected string or bytes-like object
Traceback (most recent call last):
  File "/Users/tdyas/TC/pants/src/python/pants/bin/daemon_pants_runner.py", line 148, in single_daemonized_run
    return runner.run(start_time)
  File "/Users/tdyas/TC/pants/src/python/pants/bin/local_pants_runner.py", line 257, in run
    callbacks = Subsystem.get_streaming_workunit_callbacks(streaming_handlers)
  File "/Users/tdyas/TC/pants/src/python/pants/option/subsystem.py", line 248, in get_streaming_workunit_callbacks
    subsystem = subsystem_class.global_instance()
  File "/Users/tdyas/TC/pants/src/python/pants/option/subsystem.py", line 157, in global_instance
    return cls._instance_for_scope(cls.options_scope)  # type: ignore[arg-type]  # MyPy is treating cls.options_scope as a Callable, rather than `str`
  File "/Users/tdyas/TC/pants/src/python/pants/option/subsystem.py", line 182, in _instance_for_scope
    cls._scoped_instances[key] = cls(scope, cls._options.for_scope(scope))
  File "/Users/tdyas/TC/pants/src/python/pants/util/memo.py", line 123, in memoize
    result = func(*args, **kwargs)
  File "/Users/tdyas/TC/pants/src/python/pants/option/options.py", line 420, in for_scope
    values_builder = self.for_scope(enclosing_scope(scope)).to_builder()
  File "/Users/tdyas/TC/pants/src/python/pants/option/parser_hierarchy.py", line 26, in enclosing_scope
    _validate_full_scope(scope)
  File "/Users/tdyas/TC/pants/src/python/pants/option/parser_hierarchy.py", line 20, in _validate_full_scope
    if _empty_scope_component_re.search(scope):
TypeError: expected string or bytes-like object
I have
options_scope
returning
"metrics"
h

hundreds-father-404

10/15/2020, 12:52 AM
It subclasses
Subsystem
, right? You also will want to register it with the engine, either by using it as a parameter to a rule, or by registering
SubsystemRule(MySubsystem)
and ensuring that gets put in a
register.py
Alternatively, you can include it in in
global_subsystems.py
. We’re trying to move away from that file, but it probably belongs there for now
f

fast-nail-55400

10/15/2020, 12:57 AM
There needs to be a better error message though. I listed the Subsystem as a streaming workunit handler. It would have been better for Pants to print out a useful error like “unregistered Subsystem: [name]”
h

hundreds-father-404

10/15/2020, 1:04 AM
Agreed. A plugin author was confused that they had to register
SubsystemRule
If you have a moment, opening an issue would be helpful
👍 1
p

polite-garden-50641

10/15/2020, 3:34 PM