https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

10/31/2020, 4:49 AM
I also wonder if we still need to be maintaining our own versions of the rust toolchain
a

average-vr-56795

10/31/2020, 10:09 AM
I don't think so - the rust version file should be sufficient
Also if we finally get around to moving grpc support to tonic, its protobuf generator (prost) bundles a protoc so we could stop fetching one, and we also wouldn't need cmake
h

hundreds-breakfast-49010

11/01/2020, 12:45 AM
yeah, I would think we could instruct people who clone the pants repository to use
rustup
to install a specific version of rust and use that, and save us the trouble of having to keep our own version of the toolchain
I wonder if there's a way to do this automatically. you can run
rustup override set <version>
to specify that a specific directory will use a specific version of the rust toolchain
and
rustup
is a standard enough rust ecosystem tool that I think we can safely insist that people who want to compile pants have it
so, huh, this is what the
rust-toolchain
file is for, that's a standard file that rustup reads
so theoretically if we run a system
cargo
binary in the pants repo, rustup should already do the right thing, which might be to install the specific version of the rust toolchain specified in
rust-toolchain
a

average-vr-56795

11/01/2020, 9:14 AM
Indeed ๐Ÿ™‚
I think itโ€™s reasonable for us to detect whether
cargo
is on your
$PATH
and if not, (maybe with a prompt) download and run
rustup
without specifying a custom directory to install to
And then rely on the
rust-toolchain
file and them having not done weird things
๐Ÿ‘ 1