https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-breakfast-49010

01/06/2021, 12:15 AM
@hundreds-father-404 I like this suggestion https://github.com/pantsbuild/pants/pull/11412#issuecomment-754962172 , not sure if
engine/internals
is the right place to put it since we expect plugin authors to import from it
👍 1
h

hundreds-father-404

01/06/2021, 12:16 AM
perhaps
engine
? It’s also plausible that
engine
is too large as is, and we should move some things there
h

hundreds-breakfast-49010

01/06/2021, 12:16 AM
also I'm not sure what the deprecation procedure is for moving modules around like this - toolchain code is importing
StreamingWorkunitContext
at the current module path, so there'd be an upgrade process there
h

hundreds-father-404

01/06/2021, 12:17 AM
I don’t think this is seen as a public API iiuc. It’s not marked that way, and it also isn’t documented But, you can deprecate the entire module and say in the message where to import from instead
h

hundreds-breakfast-49010

01/06/2021, 12:22 AM
we may need to make it a public API, but if we're not currently treating it as one then that makes it easier to move it around in the module path space
w

witty-crayon-22786

01/06/2021, 12:28 AM
this is a very specialized type of plugin. it’s a plugin, but i’m not sure it should be bucketed with the
@rule
plugin APIs.