@hundreds-father-404 I like this suggestion https://github.com/pantsbuild/pants/pull/11412#issuecomment-754962172 , not sure if

engine/internals

is the right place to put it since we expect plugin authors to import from it

perhaps

engine

? It’s also plausible that

engine

is too large as is, and we should move some things there

also I'm not sure what the deprecation procedure is for moving modules around like this - toolchain code is importing

StreamingWorkunitContext

at the current module path, so there'd be an upgrade process there

I don’t think this is seen as a public API iiuc. It’s not marked that way, and it also isn’t documented But, you can deprecate the entire module and say in the message where to import from instead

we may need to make it a public API, but if we're not currently treating it as one then that makes it easier to move it around in the module path space

this is a very specialized type of plugin. it’s a plugin, but i’m not sure it should be bucketed with the

@rule

plugin APIs.