Does anyone remember why ` remote store server` takes a list

Question

Does anyone remember why ` remote store server` takes a list rather than a single server like ` remote execution server` Both Tom and I have been tripped up with ` remote store server=localhost xxx` appending rather than overriding

enough-analyst-54434 · Answer

I think that used to populate a client maintained server set for load balancing Perhaps a Scoot detail that leaked into the client

hundreds-father-404 · Answer

That sounds plausible We re thinking we can address this gotcha by either 1 renaming to ` remote store servers` 2 converting to a single str both are churny but better to do now before more people use remoting and it tripped up both Tom and me for far longer than we d like to admit

average-vr-56795 · Answer

Convert to one

hundreds-father-404 · Answer

I have no idea how we deprecate something like that but okay cool Thanks

hundreds-father-404 · Answer

Okay I don t think it s possible to deprecate ` remote store server` to go from a list option to a single string through the options system Implicit adds are an issue that `store server = foo ` in `pants toml` means to add to the list rather than override This blocks converting your list syntax to a string syntax there s no middle ground you can migrate to Only options I can think of 1 Deprecate ` remote store server` to be ` remote store servers` then deprecate that to be ` remote store server` 2 Break our deprecation policy This is an Alpha API but still bleh

average-vr-56795 · Answer

Can we detect when folks have gt 1 of them and issue a warning and just make it a hard switch in type after a few releases

hundreds-father-404 · Answer

Yes but that wouldn t warn about ```store server = foo ``` And another issue we have zero idea if they re using that syntax or not It s entirely abstracted by the options system

average-vr-56795 · Answer

Yeah that s fair disappointed

average-vr-56795 · Answer

That said it s a very easy fix for folks to make so it doesn t feel like a terrible breaking change to make

witty-crayon-22786 · Answer

if you really want to do it the rename wouldn t be that onerous would just go for it

witty-crayon-22786 · Answer

` remote store host` etc

hundreds-father-404 · Answer

Bazel simply uses ` remote cache` which we could translate to ` remote store` But that s weird with ` remote execution` being a bool to disable RE mode

average-vr-56795 · Answer

Let s resolve the can we merge the flags thread before we choose the naming

hundreds-father-404 · Answer

Agreed but I think the answer is no to merging iiuc Tom pointed out he needed separate config for BuildGrid to work

average-vr-56795 · Answer

Cool slightly smiling face

hundreds-father-404 · Answer

Related to this naming Tom has proposed considering the user specifying the schema directly in the server value i e `http` vs `https` That s how Bazel does it This is what enables disables TLS I think that likely will scale better as it allows the store server to work with http https grpc grpcs and unix sockets We could add support for those if we want in the future

average-vr-56795 · Answer

Sounds good slightly smiling face

fast-nail-55400 · Answer

do we want to call the schemes `grpc` and `grpcs` then I was using Tonic s naming convention of `http` and `https` for the scheme but Tonic is a gRPC library so `https` == `grpcs` is implied by that fact

hundreds-father-404 · Answer

Oh interesting Yeah Bazel only uses ` grpc grpcs unix ` for remote execution But throws in `http` and `https` for caching To confirm we are using grpc grpcs for both services

fast-nail-55400 · Answer

REAPI is a gRPC protocol

fast-nail-55400 · Answer

so yeah only grpc and grpcs matter

fast-nail-55400 · Answer

I guess Bazel has a HTTP but non REAPI caching mode

average-vr-56795 · Answer

It does REST ish

average-vr-56795 · Answer

I haven t seen `grcp ` and `grpcs ` used anywhere and it s a little weird because you can speak gRPC over e g Unix sockets On the other hand apparently it s a scheme nginx uses <http nginx org en docs http ngx http grpc module html>

average-vr-56795 · Answer

So Probably makes sense

fast-nail-55400 · Answer

also is `unix ` only supported for the proxy config <https docs bazel build versions master remote caching html unix sockets>

fast-nail-55400 · Answer

bazel seems to still require you to use `http ` etc to configure the cache protocol

fast-nail-55400 · Answer

but `unix ` is specified separately in a proxy option when using a proxy running on a UNIX socket

average-vr-56795 · Answer

<https github com bazelbuild bazel pull 11722> added support for `unix ` for remote cache executor

fast-nail-55400 · Answer

ah so `unix` really means `grpc+unix`

fast-nail-55400 · Answer

no need for us to solve this right now though since we don t have UNIX socket support to my knowledge

hundreds-father-404 · Answer

To summarize sounds good for us to use `grpc` and `grpcs` for now

fast-nail-55400 · Answer

yup fine by me bonus is less confusion for people coming from Bazel

hundreds-father-404 · Answer

And perhaps we rename both ` remote store server` and ` remote execution server` e g ` remote store execution host` Naming suggestions I do like server but that deprecation is nigh impossible

fast-nail-55400 · Answer

endpoint

fast-nail-55400 · Answer

host

fast-nail-55400 · Answer

nook because many people might read a book or a cache in a nook

fast-nail-55400 · Answer

okay probably not that last one drum with drumsticks

average-vr-56795 · Answer

` remote store` and ` remote executor`

average-vr-56795 · Answer

I m slightly wary of host because host is typically the part after the scheme and we re proposing including the scheme

average-vr-56795 · Answer

Endpoint or server work for me too

average-vr-56795 · Answer

Or address I guess

hundreds-father-404 · Answer

I think I like address < fast nail 55400> thoughts

fast-nail-55400 · Answer

I don t have a preference between `endpoint` and `address`

fast-nail-55400 · Answer

endpoint is what Tonic calls it but that s an internal implementation detail

fast-nail-55400 · Answer

how much is `address` closer to `host` in meaning than `endpoint`

fast-nail-55400 · Answer

re inclusion of scheme

hundreds-father-404 · Answer

< witty crayon 22786> any thoughts on ` remote execution address` vs ` remote execution endpoint` I don t have much preference but am about to start implementing this

witty-crayon-22786 · Answer

nah no preference

witty-crayon-22786 · Answer

thanks for checking though