hundreds-father-404
02/10/2021, 3:09 AM--remote-store-server
takes a list, rather than a single server like --remote-execution-server
?
(Both Tom and I have been tripped up with --remote-store-server=localhost:xxx
appending, rather than overriding)enough-analyst-54434
02/10/2021, 4:37 AMhundreds-father-404
02/10/2021, 4:42 AM--remote-store-servers
2) converting to a single str
both are churny, but better to do now before more people use remoting. and it tripped up both Tom and me for far longer than we'd like to admitaverage-vr-56795
02/10/2021, 7:03 AMhundreds-father-404
02/10/2021, 7:07 AM--remote-store-server
to go from a list option to a single string through the options system..
Implicit adds are an issue, that store_server = "foo"
in pants.toml
means to add to the list, rather than override. This blocks converting your list syntax to a string syntax, there's no middle ground you can migrate to
Only options I can think of:
1. Deprecate --remote-store-server
to be --remote-store-servers
, then deprecate that to be --remote-store-server
...
2. Break our deprecation policy. This is an Alpha API, but still, blehaverage-vr-56795
02/16/2021, 9:34 PMhundreds-father-404
02/16/2021, 9:36 PMstore_server = ["foo"]
(And another issue, we have zero idea if they're using that syntax or not. It's entirely abstracted by the options system)average-vr-56795
02/16/2021, 9:37 PMwitty-crayon-22786
02/16/2021, 9:38 PM--remote-store-host
, etchundreds-father-404
02/16/2021, 9:41 PM--remote-cache
, which we could translate to --remote-store
. But that's weird with --remote-execution
being a bool to disable RE modeaverage-vr-56795
02/16/2021, 9:41 PMhundreds-father-404
02/16/2021, 9:42 PMaverage-vr-56795
02/16/2021, 9:42 PMhundreds-father-404
02/16/2021, 9:45 PMhttp
vs https
. That's how Bazel does it
This is what enables/disables TLS.
I think that likely will scale better, as it allows the store server to work with http, https, grpc, grpcs, and unix sockets. We could add support for those if we want in the futureaverage-vr-56795
02/16/2021, 9:46 PMfast-nail-55400
02/16/2021, 9:54 PMgrpc
and grpcs
then? I was using Tonic’s naming convention of http
and https
for the scheme, but Tonic is a gRPC library so https
== grpcs
is implied by that facthundreds-father-404
02/16/2021, 9:57 PM{grpc,grpcs,unix}
for remote execution. But throws in http
and https
for caching
To confirm, we are using grpc/grpcs for both services?fast-nail-55400
02/16/2021, 10:00 PMaverage-vr-56795
02/16/2021, 10:01 PMgrcp://
and grpcs//
used anywhere, and it's a little weird because you can speak gRPC over e.g. Unix sockets. On the other hand, apparently it's a scheme nginx uses: http://nginx.org/en/docs/http/ngx_http_grpc_module.htmlfast-nail-55400
02/16/2021, 10:06 PMunix://
only supported for the proxy config? https://docs.bazel.build/versions/master/remote-caching.html#unix-socketshttp://
etc. to configure the cache protocolunix://
is specified separately in a proxy option when using a proxy running on a UNIX socketaverage-vr-56795
02/16/2021, 10:11 PMunix:
for remote cache/executorfast-nail-55400
02/16/2021, 10:25 PMunix
really means grpc+unix
…hundreds-father-404
02/16/2021, 10:30 PMgrpc
and grpcs
for now?fast-nail-55400
02/16/2021, 10:31 PMhundreds-father-404
02/16/2021, 10:31 PM--remote-store-server
and --remote-execution-server
, e.g. --remote-{store,execution}-host
?
Naming suggestions? I do like server, but that deprecation is nigh impossiblefast-nail-55400
02/16/2021, 10:32 PMaverage-vr-56795
02/16/2021, 10:34 PM--remote-store
and --remote-executor
?hundreds-father-404
02/16/2021, 10:35 PMfast-nail-55400
02/16/2021, 10:36 PMendpoint
and address
address
closer to host
in meaning than endpoint
?hundreds-father-404
02/17/2021, 12:12 AM--remote-execution-address
vs --remote-execution-endpoint
? I don't have much preference, but am about to start implementing thiswitty-crayon-22786
02/17/2021, 12:12 AM