average-vr-56795
02/16/2021, 9:27 PMbuild-support/virtualenv
downloads and uses virtualenv
? I would've thought these days that whole script could be replaced with python -m venv
, given we're py3-only at this point?virtualenv
to play nice with the python interpreters I have installed on my Mac, but just doing this made it happy:
diff --git a/build-support/virtualenv b/build-support/virtualenv
index 06016fc1b..02c6bd156 100755
--- a/build-support/virtualenv
+++ b/build-support/virtualenv
@@ -24,21 +24,4 @@ fi
log "Using Python at ${PY}"
-HERE=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
-if ! [ -f "${HERE}/virtualenv.dist/BOOTSTRAPPED-${VIRTUALENV_VERSION}" ]; then
- pushd "${HERE}" >/dev/null
- VIRTUALENV_PACKAGE_FULL_URL="${VIRTUALENV_PACKAGE_LOCATION}/virtualenv-${VIRTUALENV_VERSION}.tar.gz"
- log "Downloading ${VIRTUALENV_PACKAGE_FULL_URL}..."
- curl -#L -O "${VIRTUALENV_PACKAGE_FULL_URL}" || \
- die "Failed to download ${VIRTUALENV_PACKAGE_FULL_URL}."
- rm -rf virtualenv-${VIRTUALENV_VERSION}
- tar zxf virtualenv-${VIRTUALENV_VERSION}.tar.gz || \
- die "Failed to extract ${VIRTUALENV_PACKAGE_FULL_URL}."
- # TODO(ksweeney): Checksum
- touch virtualenv-${VIRTUALENV_VERSION}/BOOTSTRAPPED-${VIRTUALENV_VERSION} && \
- rm -rf virtualenv.dist && \
- mv -f virtualenv-${VIRTUALENV_VERSION} virtualenv.dist
- popd >/dev/null
-fi
-
-exec "${PY}" "${HERE}/virtualenv.dist/virtualenv.py" "$@"
+"${PY}" -m venv "$@"
hundreds-father-404
02/16/2021, 9:28 PMenough-analyst-54434
02/16/2021, 9:29 PMensurepip
or venv
are somehow optional modules.hundreds-father-404
02/16/2021, 9:34 PMaverage-vr-56795
02/16/2021, 9:35 PMenough-analyst-54434
02/16/2021, 9:36 PMaverage-vr-56795
02/16/2021, 9:37 PMenough-analyst-54434
02/16/2021, 9:38 PMaverage-vr-56795
02/16/2021, 9:39 PMenough-analyst-54434
02/16/2021, 9:39 PMhundreds-father-404
02/16/2021, 9:39 PM