@witty-crayon-22786 would it make sense to rewrite the streaming workunit handler to Rust so we spawn the thread with tokio, rather than via Python's

thread

library?

maybe? at its core it would still need to be something like a context manager wrapped around the run (or a try:finally)… but it couldn’t literally be a context manager i don’t think

I'm a little confused how the logging is getting set up correctly to write to

pants.log

atm? Is Tokio somehow tracking what threads Python is spawning?

no, it isn’t. but the default destination for a thread with no destination set is Logging

i think that we’re likely to be spawning fewer and fewer threads in python over time

It looks like nailgun/pantsd are the only other places we do this?

yea. and i noticed the other day that ~most of nailgun is dead code.

I don't mean a "spawn a thread" API, I was envisioning that most of that logic would be in Rust itself But honestly I'm a little unclear how to proceed in general

@hundreds-father-404: in that case, just do the set/get destination thing.

Thanks. I do, but trying to knock out this other thing first to have a win hah