https://pantsbuild.org/ logo
Join Slack
Powered by
Is there no way to turn off just the global one bu...
# development
h
Is there no way to turn off just the global one but allow the repo-specific one?
h
Nope, no way according to 
shellcheck --help
. And we can't somehow isolate the program to not be able to access $HOME So, I'm thinking it's a lesser evil to not support config files at all than to risk this subtle non-reproducibility
You can emulate a config file by permanently setting 
[shellcheck].args
in 
pants.toml
Oh and maybe we can detect if 
<build root>/.shellcheckrc
is there and warn that Pants won't use it? I wonder if that'd be helpful to warn about in general?? It is a gotcha that you must tell Pants about config files via 
[tool].config
a
We could fix shellcheck? :)
e
+1
h
https://github.com/koalaman/shellcheck/issues/2197 In the meantime, I'll disable config file support. Likely in a followup, I'll add warnings in general for when we detect config files but they're not specified to Pants - we warn about that gotcha in docs, but it's easy to miss
h
Yeah sounds fine to me
This is fine as a work in progress
if someone really cares we can help them address it via contributing to shellcheck
👍 1
h
Looks like Flake8 and Pylint also consult global config files... In the absence of patching all these, I think the best we could do is warn if we detect the files? Use PathGlobsAndRoot once that is added back first-class to read outside the build root
Open in Slack
PreviousNext
Powered by