@bored-art-40741 Looks like you are making a lot of progress on JVM support, let us know if there are things we can help with 🙂 cc @great-shoe-2826

things seem to be here: https://github.com/patricklaw/pants/commits/coursier

with a draft here: https://github.com/pantsbuild/pants/pull/11890

A good, fairly independent task is to integrate the autoformatter Google-Java-formatter. It could be a good intro to the plugin API and shouldn't be as blocked on Patrick's work, eg i don't think you'd need compilation implemented Would y'all be interested in that? Not sure if you're using it or not

We are not using it, probably would be hard for us to do a good job at it

Are you using any linters? Altho I think some of those require compilation so can be trickier

we use scalafmt

Oh cool, that would be great to add an integration for! I think the only tricky part will be how to install the tool, which @happy-kitchen-89482 was saying is probably through Coursier which Patrick has been adding How would you feel about adding Scalafmt as a first project? There's a guide on adding formatters, and I can also write some additional relevant instructions. A cool result is that it would be usable immediately, even without the rest of Scala implemented. And we can help you get it working as an in repo plugin if you can't yet upgrade to 2.5 :)

Does Scalafmt require the upstream classpath in order to work? Or is it strictly operating on the structure of the source file, with no other info needed.

Are y'all using MyPy by chance? An even better starter ticket is tweaking the argv we pass to MyPy to only run over specified files, not the whole transitive closure. It's valuable and 2 users have asked for it, and it's more accessible because you're tweaking existing code rather than writing new code https://github.com/pantsbuild/pants/issues/11553

scalafmt does not require the classpath… scalafix does for “semantic” rewrites, but not for “syntactic” rewrites

Not using MyPy but that could be a good issue to start with. Scalafmt plugin would be a good idea as well. What about docker support? I seem to remember you left it out for the community to pick it up

I wouldn't recommend starting with docker - it's still not very well scoped and there isn't a guide on how to do it already. Could be cool later tho if y'all were still interested - indeed, it's very frequently requested

Yeah, the main issue with Docker support is figuring out what that means - different orgs have different needs, and the challenge is reconciling those into a general-purpose feature.

make a github project full of starter projects

I labeled things "help wanted" a few weeks ago for candidate intern projects for Liam, which are also roughly good starter issues for contributors

Labels are good, but "help wanted" doesn't really mean the same as "Good for starter projects"

will take on the scalafmt one then

@hundreds-father-404 can you give some pointers?

Yes, writing up an issue. @loud-stone-83419 how are you all installing scalafmt right now? I'm thinking we should install the Graal native images for the fastest performance. I think Pants also supports NailGun, but Graal seems simpler https://scalameta.org/scalafmt/docs/installation.html#native-image

Right now people have 2 confs - either they use pants scalafmt 1.30.x

Cool. Next question, what versions do you think we need to support? If we say it must be 2.7.0+ (Sept 2020), the installation of native binaries is much easier. Otherwise we have to handle that they changed their installation scheme on https://github.com/scalameta/scalafmt/releases, compare 2.7.0, 2.6.4, and 2.6.3 It'd be great to avoid their bash install script if possible: https://raw.githubusercontent.com/scalameta/scalafmt/master/bin/install-scalafmt-native.sh

We are using 2.7.5

We can always add back support for earlier versions if a user needs it. But start simple

Hi, just checking in to see how things are going with this?

It is a slow start - Will reach out if we need some help

SG, thanks