https://pantsbuild.org/ logo
h

hundreds-father-404

05/21/2021, 11:17 PM
@fast-nail-55400 re your suggestion that the new error message for Pantsd being killed during the run should link to pantsbuild.org: I agree. Rust complication though, we need to call
engine/src/externs/mod.rs::bracketed_docs_url()
from
engine/nailgun/src/client.rs
, which would be a circular dependency. I don't know of any way to get the nailgun crate to safely use
externs
. Do you?
f

fast-nail-55400

05/21/2021, 11:18 PM
Not offhand. Fine to skip the link for now.
👍 1
or else you’d have to extract a trait to a common module, yada yada
👍 1
But too much complication for now
h

hundreds-father-404

05/21/2021, 11:20 PM
Cool, sg. I'm definitely gonna cherry-pick this to 2.4 and 2.5 given that we have user reports of this issue on both Might only cherry-pick the actual fix to 2.5, depending on complexity