hundreds-father-404
06/07/2021, 7:58 PMwitty-crayon-22786
06/07/2021, 7:59 PMhundreds-father-404
06/07/2021, 8:00 PMwitty-crayon-22786
06/07/2021, 8:01 PMhundreds-father-404
06/07/2021, 8:04 PMwitty-crayon-22786
06/07/2021, 8:07 PMaverage-vr-56795
06/07/2021, 8:11 PMimpl Drop
?hundreds-father-404
06/07/2021, 8:12 PMtry finally
in Python landwitty-crayon-22786
06/07/2021, 8:12 PMhundreds-father-404
06/07/2021, 8:13 PMcontext.workunit_store.record_observation
?witty-crayon-22786
06/07/2021, 8:13 PMaverage-vr-56795
06/07/2021, 8:14 PMDrop
impl isn't happening...witty-crayon-22786
06/07/2021, 8:15 PMhundreds-father-404
06/07/2021, 8:29 PMshould we also fix context.workunit_store.record_observationOh hm, looks like histograms aren't associated with particular workunits, so no need
witty-crayon-22786
06/07/2021, 8:30 PMhundreds-father-404
06/08/2021, 1:53 AMwitty-crayon-22786
06/08/2021, 4:24 PMhundreds-father-404
06/08/2021, 4:25 PMtokio::select !
happy and I'd love some help if you're free. I posted a diff with what I was trying to usewitty-crayon-22786
06/08/2021, 4:32 PMhundreds-father-404
06/08/2021, 5:03 PMwitty-crayon-22786
06/08/2021, 5:07 PMhundreds-father-404
06/14/2021, 9:45 PMI see why: the closure is getting canceled before it can finishThis was not true. The workunit is not getting dropped because we used
tokio::spawn
. It should still be running, but in a background thread after the Pants session has finished
The fix is simple for this: add a new workunit that always finisheswitty-crayon-22786
06/14/2021, 10:02 PM