Hey, for our FFI port, I want to implement the trait FromPyObject on the PathGlobs struct defined in Rust. It would allow our FFI functions to request that type in function signature and do the right thing, rather than having to request a &PyAny But the struct is defined in a different crate, so rust doesn't allow adding a trait Instead, the two options seem to be: 1) create a light weight wrapper struct. Implement Deref on it so it's accessed the same, right? 2) use a free function rather than the trait. This is what we currently do. Thoughts on which is preferable?

1) would be the most idiomatic probably.

Cool, thanks!

but, also… another possibility would be to make

PyPathGlobs

a true python class, with a single field for a native

PathGlobs

I thought about that. That would mean eventually porting all our intrinsic FS types to do that, right? I'm doing this PathGlobs port as an example for how to do the rest

it doesn’t need to. can do it for performance, but if it also leads to cleaner FFI code, that’s nice too. only downside i see is that our API doc generation will need to be native-code aware.