The new JVM tests are flaking pretty regularly, ab...
# developmenth
hundreds-father-404
07/20/2021, 10:54 PMThe new JVM tests are flaking pretty regularly, about 5-10% of builds if I had to put a number on it. Okay if I turn them off until @bored-art-40741 or others have a chance to stabilize?
w
witty-crayon-22786
07/20/2021, 11:11 PMyea, let’s do it.
witty-crayon-22786
07/20/2021, 11:11 PMwill be some combination of more retry and more caching to fix it, and not sure about the precise mix.
witty-crayon-22786
07/20/2021, 11:12 PMi don’t think that we punch a hole through to share the
named_cachesf
fast-nail-55400
07/21/2021, 2:06 AMwhat parts of the test are flaking?
fast-nail-55400
07/21/2021, 2:06 AMjar downloads?
h
hundreds-father-404
07/21/2021, 2:07 AMYeah
hundreds-father-404
07/21/2021, 2:07 AMb
bored-art-40741
07/21/2021, 2:27 AMSgtm, sorry been out the last week
bored-art-40741
07/21/2021, 2:27 AMI’ll be taking a look at this over the next few days
bored-art-40741
07/25/2021, 5:09 PMOkay, taking a look at this today. First and foremost--any tips on actually debugging issues like this where it only reproduces on CI? If it's the case that this is just inherently difficult to unit test on our CI, do we have a notion of heavier-weight, more flaky integration tests that don't necessarily run on every PR but run periodically and can be used to bisect regressions?
bored-art-40741
07/25/2021, 7:23 PMI'm actually wondering if the best next move here is to open a bug against Coursier, since we have a few example stack traces, we can theoretically generate repros if needed, and it seems to me like this is likely an issue with their locking/caching, or at the very least a UX issue with the error that's surfaced
h
hundreds-father-404
07/25/2021, 8:59 PMYeah I think that makes sense to open a bug. Perhaps offer that they can close of course if they don't think the issue is with them
b
bored-art-40741
07/25/2021, 9:34 PMsg, will do that today
bored-art-40741
07/25/2021, 9:36 PMIn the meantime, I have a very hacky "fix" out for review that I hope will allow us to limp along CI testing for javac until the root cause is fixed: https://github.com/pantsbuild/pants/pull/12425
👍 1