ancient-vegetable-10556
08/12/2021, 5:27 PMancient-vegetable-10556
08/12/2021, 5:31 PMhundreds-father-404
08/12/2021, 5:39 PMI currently still calculate the invalidation digest with the requirements strings and the interpreter constraints.That should change. The digest is now only for the requirement strings, and then interpreter constraints are a distinct entry in the header
hundreds-father-404
08/12/2021, 5:40 PMInterpreterConstraints
, then doing lockfile_interpreter_constraints.is_compatible(context_ics)
hundreds-father-404
08/12/2021, 5:42 PM(Completion of this task is blocked on merging #12448)Perhaps add the
InterpreterConstraints
method as a prework PR?
I was hoping to wait a little longer before merging #12448 because it's going to hurt performance for Pants devs and result in annoying warnings for you and me w/ our M1s that we override [python-setup].interpreter_constraints
, until #12542 lands that is
(Another option is to add ignore
to the enum, which we may want to do anyways. Even if we end up deleting that before 2.7 stable goes out.)ancient-vegetable-10556
08/12/2021, 6:00 PMwitty-crayon-22786
08/12/2021, 6:00 PMignore
seems reasonable. although it should obviously be discouraged, i don’t think that removing it before launch is even critical.