<@U051221NF>: re: the config parsing changes: it w...
# developmentw
witty-crayon-22786
08/27/2021, 5:19 PM@happy-kitchen-89482: re: the config parsing changes: it would be really great at some point soon to migrate to consuming the rust code for this
witty-crayon-22786
08/27/2021, 5:20 PMbecause it’s possible that we could switch bootstrap options parsing entirely to rust as an incremental step before Subsystems are supported… and that might not be far off
👍 1
witty-crayon-22786
08/27/2021, 5:21 PMh
happy-kitchen-89482
08/27/2021, 5:21 PMThat would be great for the native client as well
w
witty-crayon-22786
08/27/2021, 5:21 PMright
h
happy-kitchen-89482
08/27/2021, 5:21 PMTo have there be just one mechanism
w
witty-crayon-22786
08/27/2021, 5:21 PMright.
witty-crayon-22786
08/27/2021, 5:22 PMto be clear, i have not actually triaged how much work it would be to switch bootstrap over… but i could imagine that switching over just Config might be an even smaller incremental step before that.
h
hundreds-father-404
08/27/2021, 6:10 PMOh that project sounds fun!
I'd love to do it if others don't get to it first. (ik John laid a lot of ground work)
e
enough-analyst-54434
08/27/2021, 6:41 PMThe main work of switching over has ~0 to do with toml - is implementing map parsing. Currently just our list parsing is implemented: https://github.com/pantsbuild/pants/blob/main/src/rust/engine/client/src/options/parse.rs
w
witty-crayon-22786
08/27/2021, 6:44 PMah, got it.
witty-crayon-22786
08/27/2021, 6:44 PM… well. hm. there is no map parsing currently, is there? i think that that is what they are proposing to add
witty-crayon-22786
08/27/2021, 6:45 PMpython dicts are currently embedded as strings, iirc
e
enough-analyst-54434
08/27/2021, 6:45 PMAnd so how does rust read those?
enough-analyst-54434
08/27/2021, 6:45 PMSo - there you go.
w
witty-crayon-22786
08/27/2021, 6:46 PMyea. assuming an incremental migration though, the Python-side
Confige
enough-analyst-54434
08/27/2021, 6:47 PMAh - ok. I find getting that piecemeal can be more effort than just doing it. But however someone wants to parcel this up that's not me - sounds fine.
w
witty-crayon-22786
08/27/2021, 6:47 PM… and then switch to toml-native maps in one place rather than two
e
enough-analyst-54434
08/27/2021, 6:51 PMI thought I remembered more. Its small, but + is special for dicts. No - apparently though.
w
witty-crayon-22786
09/08/2021, 3:59 PMmade some progress on this over the weekend. might have something i can post next weekend