https://pantsbuild.org/ logo
Join Slack
Powered by
where (in source control/GH) does this script come...
# development
p
where (in source control/GH) does this script comes from ? https://static.pantsbuild.org/setup/pants is it https://github.com/pantsbuild/setup/blob/gh-pages/pants ?
h
yes. @happy-kitchen-89482 has been working on adding versioning
p
ugh.. this repo is still using travis poop https://github.com/pantsbuild/setup/blob/gh-pages/.travis.yml
h
yeah we really don't like Travis though, and it costs the Pants project money every month to still use. Feel free to migrate to GHA if you're inspired! Only place we should maybe still use Travis is example-python. But even there, most are moving away from Travis it seems
p
I am giving it a try... let's see how far I get https://github.com/asherf/setup/actions
adding 
"pants.backend.experimental.terraform.lint.tffmt",
worked! thanks!
❤️ 1
ok, I am able to run 
fmt
on terraform targets.
🙌 1
however if I run the lint goal on the same targets, nothing seems to happen, and there are formating issues I created in my terraform files... it feels like the 
tffmt_lint
rule isn't hooked up to the lint goal. what am I missing?
@fast-nail-55400
f
It uses the 
terraform fmt -check
option when linting.
does that return non-zero exit code when run directly on the files?
also, the plugin is not using 
terraform
from the PATH
it is using an older version
I haven’t resolved https://github.com/pantsbuild/pants/pull/12307 which showed problems with trying to run the plugin with terraform v1.x
probably should have the terraform plugin use the 
indivisable
Sources support
also looking at your PR, you need a 
terraform_module
for every subdirectory
and not a top-level one that tries to recursively glob
the plugin was designed for one 
terraform_module
per directory, not sure how it works with recursively globs like that
p
fmt works just fine with a single top level BUILD file … as I can see in the screenshot
Open in Slack
PreviousNext
Powered by