https://pantsbuild.org/ logo
Join Slack
Powered by
Test issue. <https://github.com/pantsbuild/pants/p...
# development
c
Test issue. https://github.com/pantsbuild/pants/pull/12878/checks?check_run_id=3673393702 This works locally on my machine, so not sure how it suddenly spits out a rule graph error..?
E ValueError: Encountered 7 rule graph errors:
E No installed rules return the type AddPrefix, and it was not provided by potential callers of @rule(<intrinsic>(AddPrefix) -> PyDigest).
w
Possibly related to the recent interface changes: I'll take look when I get back from the dentist.
If I get it green, do you want me to land it?
c
I have another push coming as soon as my tests pass locally after merge with latest main, then it’s good to go, thanks 🙂
I’ve swapped hard coded search path for [shell-setup].executable-search-paths.
🙌 1
Ah, but yes, you’re probably right on the interface thing.. now when I’m on latest main, I get the same error locally too.
👀 1
I’ve pushed it as-is, if you can make sense of it, great 😄
w
pushed a fix: sorry about that
👍 1
c
@witty-crayon-22786 how did you deduce it to be archive rules missing?
w
i debugged the same issue in the first change for https://github.com/pantsbuild/pants/issues/12934
if you enable trace logging (…which isn’t trivial in a test, sorry: see) you get out a dot graph of the portion that is errored
and that portion showed that the reason it was looking for a 
PyDigest
was that there was a 
Get(PyDigest, CreateArchive)
call… but the error message rendering recursed below it.
i’ve made good progress on https://github.com/pantsbuild/pants/issues/11269 … hoping it might be in draft in the next two weeks or so
c
Ah, cool. Thanks for the details. Will read up on those tomorrow 😉
OK, this is another tomorrow 😛
there was a 
Get(PyDigest, CreateArchive)
 call… but the error message rendering recursed below it.
That spurred me to submit this PR: https://github.com/pantsbuild/pants/pull/13992
w
thanks! will look when i get on top of the holiday reviews
funnily enough, i spent some more time on 11269 over the break, but always happy to land an incremental improvement
❤️ 1
👍 1
Open in Slack
PreviousNext
Powered by