and for others: building helm results in this error:

go: <http://github.com/hashicorp/consul/sdk@v0.3.0|github.com/hashicorp/consul/sdk@v0.3.0> (replaced by ../sdk): reading ../sdk/go.mod: open /private/var/folders/md/0q71p41n0rbgwhnc8npjjzg00000gn/T/sdk/go.mod: no such file or directory

the issue is probably the fact that the replace directive in the transitive dependency is being applied.

and it shouldn’t be applied only the replace directives in the main module should have effect.

https://golang.org/ref/mod#go-mod-file-replace:

replace

directives only apply in the main module’s

go.mod

file and are ignored in other modules. See Minimal version selection for details.

this probably occurs because the Go plugin currently extracts the third-party module metadata by constructing an input root with the third-party module treated as if it were first party by

go

since the command references the packages using

./…

. https://github.com/pantsbuild/pants/blob/a57985b22160ab717adcadf0ab07995f870e2c34/src/python/pants/backend/go/util_rules/third_party_pkg.py#L2[…]281

thus

go list

thinks it should apply replace directives in in that instance

we should probably have the command be `go list -m -json FULL_IMPORT_PATH_TO_MODULE/…`and keep the source code in the input root in the original GOPATH location

Bummer, didn't work. Added a failing test at https://github.com/pantsbuild/pants/pull/13349

Hm @fast-nail-55400, I was only able to get

go list -json

working by having the chroot include

<http://github.com/hashicorp/consul/sdk@v0.3.0|github.com/hashicorp/consul/sdk@v0.3.0>

and renaming the folder to

sdk

w/o the version... That was really important for performance that running

go list

on a downloaded module uses a chroot with only that module, not sibling modules

Yeah, so, we'd do something like

go mod edit -json

to find this:

"Replace": [
		{
			"Old": {
				"Path": "<http://github.com/hashicorp/consul/sdk|github.com/hashicorp/consul/sdk>"
			},
			"New": {
				"Path": "../sdk"
			}
		}
	],

We know the import path is

<http://github.com/hashicorp/consul/api|github.com/hashicorp/consul/api>

, so we calculate it's trying to load

<http://github.com/hashicorp/consul/sdk|github.com/hashicorp/consul/sdk>

when you apply the

../sdk

. We see if there is that downloaded module. If so, the

Digest

for

consul/api

has to also include

consul/sdk

Huzzah! @fast-nail-55400 your approach works. See the experiment I put up at https://github.com/pantsbuild/pants/pull/13349/files

and nice!

no pressure, just curious re: 2.8.0rc1

It's ready to merge fwict