fast-nail-55400
11/04/2021, 7:08 PMhundreds-father-404
11/04/2021, 7:11 PMFallibleFirstPartyPkgInfo
was before: gracefully handle the error. Don't crash Pants, but also indicate it was a failure so that callers can decide what to do
check
will output it as a failure, for example. package
should crash and burnfast-nail-55400
11/04/2021, 7:13 PMcheck
will try to compile it and the failure will be the compile failurehundreds-father-404
11/04/2021, 7:15 PMcheck
will not compile if analysis failed. Check out go/goals/check.py
fast-nail-55400
11/04/2021, 7:17 PMcheck
will try and compilehundreds-father-404
11/04/2021, 7:20 PMFirstPartyPkgInfo
always be infallabile, altho that isn't reason enough imo to make the semantic changefast-nail-55400
11/04/2021, 7:22 PMhappy-kitchen-89482
11/04/2021, 7:22 PMfast-nail-55400
11/04/2021, 7:24 PMhundreds-father-404
11/04/2021, 7:26 PMcheck
, test
, and package
attempt to compile bad packages, rather than early aborting
Does that sound right?fast-nail-55400
11/04/2021, 7:28 PMhundreds-father-404
11/04/2021, 7:30 PMFallibleFirstPartyPkgInfo
?fast-nail-55400
11/04/2021, 8:00 PMhappy-kitchen-89482
11/04/2021, 9:49 PM