https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

11/08/2021, 5:46 PM
Hm...why would we still release
pantsbuild.pants.testutil
as a separate distribution to PyPI from
pantsbuild.pants
? I think we can simplify.
I presumed it's for
pantsbuild.pants
to be as small as possible for non-plugin users, but shaving 23kb off of a ~7mb (macOS) or 55mb (linux) dist is irrelevant.
e

enough-analyst-54434

11/08/2021, 5:53 PM
Who is this actively confusing or making life more complex for?
h

happy-kitchen-89482

11/08/2021, 5:54 PM
We might want to make that change, but it doesn't seem urgent to make it now?
h

hundreds-father-404

11/08/2021, 5:55 PM
The context is https://github.com/pantsbuild/pants/pull/13512. It simplifies this:
Copy code
pants_requirement()
pants_requirement(dist="pantsbuild.pants.testutil")
To
Copy code
pants_requirements()
But it got me thinking, what's the benefit of two dists in the first place?
We might want to make that change, but it doesn't seem urgent to make it now?
Agreed on not being very urgent
h

happy-kitchen-89482

11/08/2021, 5:56 PM
and it might end up causing us to bundle future test time requirements into core pants (like a mocking library or something like that, in the future)
👍 1
h

hundreds-father-404

11/08/2021, 5:58 PM
Ah good point! So we would probably want to have a
[test]
extra if we were to consolidate. And at that point, it's just a different typing from what we have before So, status quo does seem to have some reason to still be that way! Thanks