tricky (but probably also low priority?) thing tha...
# developmentw
witty-crayon-22786
11/08/2021, 9:13 PMtricky (but probably also low priority?) thing that i expect that you all are not seeing in `guice`:
witty-crayon-22786
11/08/2021, 9:13 PMhttps://github.com/pantsbuild/pants/pull/13214 wasn’t quite right
witty-crayon-22786
11/08/2021, 9:13 PMalthough a symbol in an unnamed package is not available outside of a package, it is available inside of the unnamed package
a
ancient-vegetable-10556
11/08/2021, 9:14 PM@witty-crayon-22786 I don’t believe so. I’m seeing cross-package issues
w
witty-crayon-22786
11/08/2021, 9:15 PMthe effect of fixing that for this repository though would be a ton of ambiguity (tens of these projects have classes named e.g.
Employeewitty-crayon-22786
11/08/2021, 9:15 PMso… 1) probably not a priority, 2) would require special casing.
a
ancient-vegetable-10556
11/08/2021, 9:16 PMI’m not certain what you’re talking about?
w
witty-crayon-22786
11/08/2021, 9:18 PMhave been working in https://github.com/toolchainlabs/hazelcast-code-samples/tree/stuhood/pants … files like https://github.com/toolchainlabs/hazelcast-code-samples/blob/stuhood/pants/distributed-map/entry-processor/src/main/java/NaiveProcessingMember.java are in the unnamed package
witty-crayon-22786
11/08/2021, 9:18 PMand they reference other classes in their own unnamed package
a
ancient-vegetable-10556
11/08/2021, 9:18 PMOh! You’re talking about the different repo that you’re working on. I get it now.
w
witty-crayon-22786
11/08/2021, 9:18 PMto special case it, we’d have to distinguish “this unnamed package” from “that unnamed package”
witty-crayon-22786
11/08/2021, 9:23 PM…eh. i guess i could still fix it, and then at least folks will get a ton of ambiguity warnings, even without the special casing.
a
ancient-vegetable-10556
11/08/2021, 9:23 PMthe distinction is its source file location, right?
w
witty-crayon-22786
11/08/2021, 9:23 PMthe implied compilation unit, yea