witty-crayon-22786
11/15/2021, 8:30 PMcreate-thirdparty.sh
creates 3rdparty BUILD files from a build.sbt
file … very hackilyancient-vegetable-10556
11/16/2021, 8:10 PMwitty-crayon-22786
11/16/2021, 8:10 PMancient-vegetable-10556
11/16/2021, 8:11 PMwitty-crayon-22786
11/16/2021, 8:12 PMancient-vegetable-10556
11/16/2021, 8:12 PMwitty-crayon-22786
11/16/2021, 8:12 PMancient-vegetable-10556
11/16/2021, 8:12 PMrule_runner
in javac_tests
, but there’s so many errors I can’t figure out which thing I’m missingwitty-crayon-22786
11/16/2021, 8:14 PMancient-vegetable-10556
11/16/2021, 8:14 PMwitty-crayon-22786
11/16/2021, 8:48 PMancient-vegetable-10556
11/16/2021, 8:51 PMjava_parser_test
, not javac_test
, but stillwitty-crayon-22786
11/16/2021, 8:51 PMancient-vegetable-10556
11/16/2021, 8:51 PMwitty-crayon-22786
11/16/2021, 8:52 PMancient-vegetable-10556
11/16/2021, 8:53 PMwitty-crayon-22786
11/16/2021, 8:54 PMjavac
now depends on the inference rulesancient-vegetable-10556
11/16/2021, 8:54 PMrule_runner
about that dependencywitty-crayon-22786
11/16/2021, 8:55 PMancient-vegetable-10556
11/16/2021, 8:56 PMwitty-crayon-22786
11/16/2021, 8:57 PMParsedJavaImports
is orphaned. looks like src/python/pants/backend/java/dependency_inference/import_parser.py
(and its test) can be deleted entirelyancient-vegetable-10556
11/16/2021, 9:02 PMjava_parser_test
witty-crayon-22786
11/16/2021, 9:03 PMimport_parser_test.py
which was also broken𐄂 src/python/pants/backend/java/dependency_inference/import_parser_test.py:tests failed.
𐄂 src/python/pants/backend/java/dependency_inference/java_parser_test.py:tests failed.
𐄂 src/python/pants/backend/java/test/junit_test.py:tests failed.
ancient-vegetable-10556
11/16/2021, 9:04 PMjava_parser_test
is failing, which is something to do with the new types I addedwitty-crayon-22786
11/16/2021, 9:10 PMjunit_test.py
is probably because it doesn’t use the inference rules. now that javac
depends on them, it should probably export themjava_parser_test
is still a mystery though.ancient-vegetable-10556
11/16/2021, 9:10 PMrules
?witty-crayon-22786
11/16/2021, 9:11 PMsrc/python/pants/backend/java/dependency_inference/java_parser_test.py
does depend on the javac rules for some reason. it probably doesn’t need to. but exporting the new dependency for javac
might fix it tooancient-vegetable-10556
11/16/2021, 9:12 PMwitty-crayon-22786
11/16/2021, 9:12 PMjavac
dep for java_parser_test.py
works.junit
, should export the inference rules from javac.ancient-vegetable-10556
11/16/2021, 9:12 PMwitty-crayon-22786
11/16/2021, 9:13 PMdiff --git a/src/python/pants/backend/java/dependency_inference/java_parser_test.py b/src/python/pants/backend/java/dependency_inference/java_parser_test.py
index caa2e9c049..0682121483 100644
--- a/src/python/pants/backend/java/dependency_inference/java_parser_test.py
+++ b/src/python/pants/backend/java/dependency_inference/java_parser_test.py
@@ -7,7 +7,6 @@ from textwrap import dedent
import pytest
-from pants.backend.java.compile.javac import rules as javac_rules
from pants.backend.java.dependency_inference.java_parser import (
FallibleJavaSourceDependencyAnalysisResult,
)
@@ -43,7 +42,6 @@ def rule_runner() -> RuleRunner:
*external_tool_rules(),
*java_parser_launcher_rules(),
*java_parser_rules(),
- *javac_rules(),
*source_files.rules(),
*util_rules(),
*jdk_rules.rules(),
ancient-vegetable-10556
11/16/2021, 9:15 PMBLAH
witty-crayon-22786
11/16/2021, 9:19 PMjavac
now depends on the inference rulesancient-vegetable-10556
11/16/2021, 9:20 PMwitty-crayon-22786
11/16/2021, 9:21 PM