blargh. most of these repos have legit java/scala ...
# developmentw
witty-crayon-22786
11/16/2021, 11:46 PMblargh. most of these repos have legit java/scala cycles. i might have to lean in on https://github.com/pantsbuild/pants/issues/13520
witty-crayon-22786
11/16/2021, 11:46 PMi wonder if they realize it.
witty-crayon-22786
11/16/2021, 11:47 PMfor example, a 252 file long cycle in `akka-http`: https://gist.github.com/stuhood/32e5389bcb86df81abb5aea6185da2dc
witty-crayon-22786
11/17/2021, 12:01 AM…i’ve spot checked 10 edges, and they’re all legit. but this seems like a great opportunity for a “these symbols are why you have a cycle!” goal (the debug goals helped a lot here!)
witty-crayon-22786
11/17/2021, 12:01 AMalright. darn. let’s do https://github.com/pantsbuild/pants/issues/13520
🚀 1
👀 1
🔥 2
h
happy-kitchen-89482
11/17/2021, 12:14 AMI'm surprised this is that common, but hey
w
witty-crayon-22786
11/17/2021, 12:14 AMi think that it’s because zinc makes “huge” projects feasible, and will silently do multiple rounds of compilation for java+scala within a project
witty-crayon-22786
11/17/2021, 12:15 AMBUT, the cycle completely disables incremental compilation for all members, so i think it’s mostly just a silent problem.
witty-crayon-22786
11/17/2021, 12:18 AMthis is 252 files out of 482 in the
akka-http-corewitty-crayon-22786
11/17/2021, 12:19 AMoh, lol. flashback: https://twitter.com/stuhood/status/665363790733578240
witty-crayon-22786
11/17/2021, 12:21 AMmaking it a not silent problem in Pants will be important.
👍 1
witty-crayon-22786
11/17/2021, 12:23 AMcc @ancient-vegetable-10556: ^ maybe interesting for the post
a
ancient-vegetable-10556
11/17/2021, 12:23 AMThank yoU!
w
witty-crayon-22786
11/17/2021, 12:23 AMmaybe we can add a warning for cycles larger than X
witty-crayon-22786
11/17/2021, 12:24 AMor some other more ergonomic assist