https://pantsbuild.org/ logo
#development
Title
# development
a

ancient-vegetable-10556

12/03/2021, 8:26 PM
@witty-crayon-22786 @fast-nail-55400 I’ve just added remote URL support to coursier resolves (review: https://github.com/pantsbuild/pants/pull/13793); I’m considering adding
file://
support as a fast-follow, just to keep the reviews scoped appropriately. Does that make sense?
w

witty-crayon-22786

12/03/2021, 8:40 PM
Yea, seems fine.
I think that we could reasonably support only relative file: urls to start, and in that case the implementation (via globs) is completely different from http
a

ancient-vegetable-10556

12/03/2021, 8:42 PM
Considering whether to implement it as: • Support for
file://
and using
PathGlobs
to yoink the files into the
CoursierResolve
process • Implementing a new
local_jvm_artifact
type
w

witty-crayon-22786

12/03/2021, 8:43 PM
Mm. Or, third option: give jvm_artifact another field
file
a

ancient-vegetable-10556

12/03/2021, 8:44 PM
Right. That’d still involve the aforementioned yoinking 😉
w

witty-crayon-22786

12/03/2021, 8:44 PM
Yep.
a

ancient-vegetable-10556

12/03/2021, 8:45 PM
I’m just wondering if I want to make it easier to do it as a filter step
w

witty-crayon-22786

12/03/2021, 8:45 PM
Well I think they should probably all involve yoinking: if we give coursier an absolute file url inside the repo, we won't get file invalidation
a

ancient-vegetable-10556

12/03/2021, 8:45 PM
which is where a separate target type would help.
Sure