https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

12/06/2021, 4:45 PM
@fast-nail-55400, @ancient-vegetable-10556: good morning!
a

ancient-vegetable-10556

12/06/2021, 4:45 PM
GOOD MORNING
👋 1
😎 1
w

witty-crayon-22786

12/06/2021, 4:46 PM
@fast-nail-55400: from performance triage so far, it looks like we will want to implement 12716
(after 13813 goes in)
since you kicked 12716 off, are you interested in tackling it?
if so: that would leave the file URL change and scalapb support for @ancient-vegetable-10556 and i: i’m fine with doing either
caught up on code review now
so… any thoughts on this?
@fast-nail-55400: one wildcard is that it might be better to have you focus on BSP, although that decision won’t be made until this afternoon.
@ancient-vegetable-10556: which of those two do you want?
a

ancient-vegetable-10556

12/06/2021, 6:57 PM
I’ll do the URL change, my mind is already there
w

witty-crayon-22786

12/06/2021, 6:57 PM
ok, thanks.
f

fast-nail-55400

12/06/2021, 6:59 PM
I’m neutral on doing 12716. Let’s discuss on call this afternoon.
In the meantime, going to finish scalafmt support.
w

witty-crayon-22786

12/06/2021, 6:59 PM
i think that i’ll get on the
scalapb
thing then.
ok. great to see it landing! just note that formatting isn’t part of this milestone, so should timebox what we’re doing there.
f

fast-nail-55400

12/06/2021, 7:02 PM
it literally was a weekend project. I tried to do scalapb first this weekend but hit a technical decision to be made which I put into the issue. see https://github.com/pantsbuild/pants/issues/13469#issuecomment-986170794.
(i.e., which is the preferred invocation mode for scalapb)
w

witty-crayon-22786

12/06/2021, 7:20 PM
aaaactually. it might make sense for me to tackle the compiler plugin one instead, since i have some context there, and since you have context on
scalapb
.
f

fast-nail-55400

12/06/2021, 7:30 PM
well let’s discuss on the call, I also had a thought on compiler options. (The thought is that they should be a
flagset
target type instead of a config option, and then other targets can refer to them by address.)
w

witty-crayon-22786

12/06/2021, 7:30 PM
yea, possibly.
@fast-nail-55400: hm actually, did you mean https://github.com/pantsbuild/pants/issues/13664 …? compiler plugins might not require additional compiler arguments beyond being enabled/disabled, so it might be that they are enabled by name
the
flagset
idea is really related to https://github.com/pantsbuild/pants/issues/13767 though
f

fast-nail-55400

12/06/2021, 8:44 PM
Will have to review those tickets to refresh my memory.