Join Slack
Communities
Powered by
I noticed this string in an exception being raised...
# development
b
bitter-ability-32190
12/12/2021, 4:52 PM
I noticed this string in an exception being raised (didn't hit the exception, just looking at the code). Is it meant to trail off?
https://github.com/pantsbuild/pants/blob/main/src/python/pants/engine/target.py#L966
👀 1
bitter-ability-32190
12/12/2021, 4:55 PM
I ask because I'm using this code as basis for some of my own 😉
bitter-ability-32190
12/12/2021, 4:58 PM
Seems like it's mean't to somewhat copy this message:
https://github.com/pantsbuild/pants/blob/6ccc196937d60208a8dbb626d838938955598786/src/python/pants/engine/target.py#L2405
e
enough-analyst-54434
12/12/2021, 5:03 PM
Yeah, definitely not meant to trail off. Eric has a mission of providing actionable details in error messages whenever possible.
➕ 2
h
hundreds-father-404
12/12/2021, 6:01 PM
oops, thanks!
b
bitter-ability-32190
12/12/2021, 9:28 PM
That's a very good mission!
❤️ 1
Open in Slack
Previous
Next