witty-crayon-22786
12/16/2021, 7:00 PMdeploy_jar
,
2. (scala_)junit_tests
3. (any other root target)hundreds-father-404
12/16/2021, 7:04 PMsince it’s likely that folks have test targets depending on other test targets, despite that being questionable)Is it? This is a huge reason I felt so strongly about https://github.com/pantsbuild/pants/issues/13238 for Python land. (Although in Python, it is legal for a test to import another test)
witty-crayon-22786
12/16/2021, 7:04 PMField
on the targets, or the Target
type itselfhundreds-father-404
12/16/2021, 7:06 PMwitty-crayon-22786
12/16/2021, 7:07 PMIs it?it might be alright if the testrunner is carefully configured to only run the root tests, rather than all tests on the path. but otherwise it leads to tests running multiple times: once for each test target that depends on them. it’s also never a good idea for library/prod code to depend on tests, and “no dependees” defends against that as well
resolve
field is a really obvious marker. but i do think that we’re going to want to replace it with compatible_resolves
for consistencyhundreds-father-404
12/16/2021, 7:08 PMwitty-crayon-22786
12/16/2021, 7:08 PMI’m questioning if people actually are doing that in the wild?in a random tailored repo… probably? but perhaps not.
hundreds-father-404
12/16/2021, 7:09 PMwitty-crayon-22786
12/16/2021, 7:10 PMTo be clear, are you thinking of inferred dependencies between tests? That regardless of Pants, you have Java test code that imports another test file?right. especially since it is file level
hundreds-father-404
12/16/2021, 7:10 PM