Why does `importlib import module a module ` go in the strin

Question

Why does `importlib import module a module ` go in the string imports bucket but ` import a module ` not

bitter-ability-32190 · Answer

Is it just harder to identify because you d techincally have to look for `import importlib` `importlib import module` `from importlib import import module` `import module` `from importlib import import module as imp mod` `imp mod`

hundreds-father-404 · Answer

it should make no difference String imports literally just analyze every string using Python s AST Are you sure it s `a module` in both cases You may need to play with this option <https www pantsbuild org docs reference python infer section string imports min dots>

bitter-ability-32190 · Answer

I m asking just because I m using this as prior art for another feature nerd face

happy-kitchen-89482 · Answer

Are you saying that we treat ` import ` the same as `import` so its arg is treated like a literal import instead of a string import

happy-kitchen-89482 · Answer

I forget how that code goes

bitter-ability-32190 · Answer

Yeah See <https github com pantsbuild pants blob 52dc7a83f9e7bdb1a24cc3d7bedc5c8373646288 src python pants backend python dependency inference import parser py L73|https github com pantsbuild pants blob 52dc7a83f9e7bdb1a24cc3d7bedc5c8373646288 src python pants backend python dependency inference import parser py L73> and line 76 and 87

happy-kitchen-89482 · Answer

Ah right

happy-kitchen-89482 · Answer

I think we did that because it s commonly used in ` init py` files

happy-kitchen-89482 · Answer

So I don t think there s a strong reason we didn t do the same for `importlib import module` other than it s not commonly used

happy-kitchen-89482 · Answer

If there was a need those could be considered real imports

bitter-ability-32190 · Answer

I assume the only case it d be catching is either string imports are off or the module name doesn t meet the min dots requirement

bitter-ability-32190 · Answer

Related <https github com pantsbuild pants pull 14049>