I didn't realize this when making the feature originally (it was my first real feature, dont @-me 😉 ) but I think we want to omit string imports from the error behavior. Otherwise,

string_imports

would be too noisy, as devs would need to

# pants: ignore

a bunch of lines 🤮

So

unowned_dependency_behavior

would only apply to things we're sure are imports: • Import statement •

__import__

calls with constant string first arg • (When support is added)

importlib.import_module

with a constant string arg

So the return of running

import_parser

separates the "confident" from the "maybe"

So I agree

Not string-related, but should Pants try and detect

try: import X except ImportError: # do whatever

as a "maybe" import?

I think so (but that could be a follow-up PR to the above)