hundreds-father-404
01/15/2022, 12:12 AMregex-lint
be activated by default or you have to add a backend for it?[regex-lint].config
for it to work.
The issue is that it causes this annoying output with lint
ā autoflake succeeded.
ā isort succeeded.
- regex-lint skipped.
FieldSet.is_applicable()
in core/goals/lint.py
to proactively determine whether the tool should run or not.
I don't think that's feasible here because we need to access a subsystem to determine if regex-lint
is activated or not, which requires using the Rules API. Compared to FieldSet.is_applicable()
just using the Target API and plain-and-simple Python functions - no engine magicwitty-crayon-22786
01/15/2022, 12:23 AMproud-dentist-22844
01/15/2022, 6:20 AMhundreds-father-404
01/29/2022, 4:04 AMregex-lint
should live in...(A Pants-provided linter where you define regexes and Pants checks them, e.g. for copyright compliance)
All I can think of
⢠pants.backend.lint.regex_lint
⢠pants.backend.utils.regex_lint
curved-television-6568
01/29/2022, 8:12 AMhundreds-father-404
01/29/2022, 1:22 PMregex-lint
was skipped, which is noisy.
I could hack around it by adding a boolean toggle to LintResults
like disabled=True
...That's a code smell, but it's possible. Wdyt?--black-skip
to temporarily skip.
Or, maybe it's not actual that useful to render in the summary skipped? If we stop doing that, this problem is solved.
./pants --isort-skip fmt ::
ā autoflake succeeded.
- isort skipped.
Here, we wouldn't show isort
at all anymore. I think there's a minor risk that you set [isort].skip = true
in pants.toml
and don't realize why it's not running, but that fear is probably overblown...Thoughts?curved-television-6568
01/29/2022, 1:47 PMhundreds-father-404
01/29/2022, 1:49 PMlint --only=<name>
right now š