I m thinking folks will like this one

Question

I m thinking folks will like this one <https github com pantsbuild pants pull 14306> smile

bitter-ability-32190 · Answer

If people like it I ll reset approvals and blast the codebase with the retrofit

hundreds-father-404 · Answer

This is awesome gt and blast the codebase with the retrofit Let s save that for followup Start with an easy to understand change w good tests and then probably still those 2 examples Makes it easier to understand Git history + revert things if we ever need

bitter-ability-32190 · Answer

Fine with me and yeah I should ve said tests are a given grin

bitter-ability-32190 · Answer

also commenting here because I m on mobile unfortunately there s no runtime access to the generic type for good reason so without some EXTRA magic it s impossible But also that s a good thing as the property type isn t necessarily the flag type Same as why it s ok ish you specify the attr name and repeat it as a flag name

hundreds-father-404 · Answer

agreed I don t think we should try inferring the type from MyPy type hint Also that type hint is totally legal to leave off

hundreds-father-404 · Answer

But it is a source of confusion imo So I m not 100 sold we shouldn t continue to require `type` as a kwarg seems probable but better for that to be a dedicated change

bitter-ability-32190 · Answer

Very fair point

hundreds-father-404 · Answer

you got mail wink very excited about the idea of `BoolOption` and `StringOption`

bitter-ability-32190 · Answer

Same

hundreds-father-404 · Answer

now that you ve shown the light I m extra frustrated adding a new option the old way see no evil

bitter-ability-32190 · Answer

Lol yeah I got frustrated every time I had to rename the now named assets options rolling on the floor laughing

hundreds-father-404 · Answer

ready for me to merge

bitter-ability-32190 · Answer

Oh yeah And fwiw love your subclass idea

bitter-ability-32190 · Answer

This is gonna be fun

bitter-ability-32190 · Answer

Nobody better steal my refactoring rights rolling on the floor laughing

hundreds-father-404 · Answer

Oh you know what we limit `type=` to what is on here <https www pantsbuild org docs rules api subsystems type> There is less flexibility than the Target API We might want to consider renaming `Option` to ` Option` and only exposing `BoolOption` etc Idea being to keep the API interface smaller while we figure out the best idioms for this all

bitter-ability-32190 · Answer

Let me try that as we refactor the code

bitter-ability-32190 · Answer

but probably still in separate PR

bitter-ability-32190 · Answer

Coming soon to a PR near you concretely typed options Hopefully tomorrow

bitter-ability-32190 · Answer