bitter-ability-32190
01/29/2022, 4:51 PMhundreds-father-404
01/29/2022, 5:23 PMand blast the codebase with the retrofitLet's save that for followup. Start with an easy-to-understand change w/ good tests and then probably still those 2 examples Makes it easier to understand Git history + revert things if we ever need.
bitter-ability-32190
01/29/2022, 5:23 PMhundreds-father-404
01/29/2022, 5:27 PMtype
as a kwarg -- seems probable, but better for that to be a dedicated changebitter-ability-32190
01/29/2022, 5:36 PMhundreds-father-404
01/29/2022, 5:36 PMBoolOption
and StringOption
bitter-ability-32190
01/29/2022, 5:43 PMhundreds-father-404
01/29/2022, 8:20 PMbitter-ability-32190
01/29/2022, 8:53 PMhundreds-father-404
01/30/2022, 2:37 AMbitter-ability-32190
01/30/2022, 9:10 AMhundreds-father-404
01/30/2022, 2:32 PMtype=
to what is on here: https://www.pantsbuild.org/docs/rules-api-subsystems#type. There is less flexibility than the Target API
We might want to consider renaming Option
to _Option
and only exposing BoolOption
etc. Idea being to keep the API interface smaller while we figure out the best idioms for this allbitter-ability-32190
01/30/2022, 4:51 PM