https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

02/01/2022, 12:21 AM
Hm @ancient-vegetable-10556 and @witty-crayon-22786, we never deprecated the first version of lockfile metadata for tool lockfiles, that uses
requirements_invalidation_digest
rather than
generated_with_requirements
That new scheme came out in 2.8. Do you think it's fine to delete support for the old scheme in 2.10 without a deprecation, or we need to do a proper deprecation? Asking because I think deleting it will make this code easier to work with for multiple user lockfiles
a

ancient-vegetable-10556

02/01/2022, 12:23 AM
v1 metadata doesn’t need to work for user lockfiles either way, but we should probably do a deprecation, just in case.
h

hundreds-father-404

02/01/2022, 12:25 AM
Okay. @ancient-vegetable-10556 would you be willing to please look into how we can deprecate it? I'll go ahead assuming we need to keep it with trying to get multiple lockfile validation to work
a

ancient-vegetable-10556

02/01/2022, 12:25 AM
I’ll deprecate it, but we never supported V1 metadata for user lockfiles, so we shouldn’t need to support it for multiples, right?
h

hundreds-father-404

02/01/2022, 12:29 AM
Agreed, but our LockfileValidation code + the
Lockfile
type from
pex.py
does not currently differentiate between tools and user lockfiles. I was trying to figure out if I can do thigns like remove
lockfile_hex_digest
from
Lockfile
to make this code easier to deal with. (That's my usual approach: try to simplify before adding new things) I think I see a way to work around that, thanks to your foresight with
ToolDefaultLockfile
existing