witty-crayon-22786
02/09/2022, 8:14 PMpython_source
doesn’t end up being a file address? apparently we have an accommodation in place to allow looks with a file address to succeed for thoseaddress
or atom
, although we do have https://github.com/pantsbuild/pants/issues/12917 … but IMO, we should not ever remove ithundreds-father-404
02/09/2022, 8:20 PMpython_source
target have a file address. Not sure how that would work - you risk a collision with a generated targetapparently we have an accommodation in place to allow looks with a file address to succeed for thoseWe do?
witty-crayon-22786
02/09/2022, 8:21 PMhundreds-father-404
02/09/2022, 8:23 PMat this point, in favor of a smaller ticket about this wart?I tbh still am generally pro-replacing file addresses with generated target syntax because: 1) consistency, especially w/ adding parametrization to make an even bigger matrix of address variants 2) the
../../tgt
part
But I think I lost this discussion. Most were generally pro file address when last discussed, and you are more fiercely pro-file address than I am anti
(and I see your point about copying and pasting, I indeed copy and paste all the time into my IDE to edit tests that are failing. Very convenient)witty-crayon-22786
02/09/2022, 8:24 PMhundreds-father-404
02/09/2022, 8:25 PMwitty-crayon-22786
02/09/2022, 8:27 PMValueError: The address `src/protobuf/dir/f.proto` was not generated by the target `src/protobuf/dir:dir`, which only generated these addresses
in https://github.com/pantsbuild/pants/runs/5118546407?check_suite_focus=truehundreds-father-404
02/09/2022, 8:50 PMwitty-crayon-22786
02/09/2022, 8:50 PMpython_requirement
, huh. i think that that was the case where we last talked about thishundreds-father-404
02/09/2022, 9:04 PMwitty-crayon-22786
02/09/2022, 9:34 PMpython_requirement
, its name is some/explicit:name
rather than some/explicit#name
(or w/e)hundreds-father-404
02/09/2022, 9:36 PMpython_requirement
for it to be #
rather than :
?witty-crayon-22786
02/09/2022, 9:42 PM