do you recall whether we opened a tic

Question

< hundreds father 404> do you recall whether we opened a ticket about the fact that the address of singleton atom file targets like `python source` doesn t end up being a file address apparently we have an accommodation in place to allow looks with a file address to succeed for those

witty-crayon-22786 · Answer

which i ll need to preserve but want to reference something

witty-crayon-22786 · Answer

no matches for `address` or `atom` although we do have <https github com pantsbuild pants issues 12917> but IMO we should not ever remove it

witty-crayon-22786 · Answer

< hundreds father 404> do you feel comfortable closing at this point in favor of a smaller ticket about this wart

hundreds-father-404 · Answer

No no design has been proposed iirc for how to have a `python source` target have a file address Not sure how that would work you risk a collision with a generated target

hundreds-father-404 · Answer

gt apparently we have an accommodation in place to allow looks with a file address to succeed for those We do

witty-crayon-22786 · Answer

hundreds-father-404 · Answer

gt at this point in favor of a smaller ticket about this wart I tbh still am generally pro replacing file addresses with generated target syntax because 1 consistency especially w adding parametrization to make an even bigger matrix of address variants 2 the ` tgt` part But I think I lost this discussion Most were generally pro file address when last discussed and you are more fiercely pro file address than I am anti and I see your point about copying and pasting I indeed copy and paste all the time into my IDE to edit tests that are failing Very convenient

witty-crayon-22786 · Answer

yea just based on my workflow it would be a horrible setback not to have a contiguous filename anywhere

witty-crayon-22786 · Answer

opened <https github com pantsbuild pants issues 14419> for this i think that there is probably a good reference for the remove requiring a name issue but i don t know what it is

hundreds-father-404 · Answer

hundreds-father-404 · Answer

altho I m skeptical my claims this will work are true

hundreds-father-404 · Answer

<https pantsbuild slack com archives C0D7TNJHL p1644438087279269 thread ts=1644437667 231959 amp cid=C0D7TNJHL> Huh that was definitely meant to be cleaned up iirc Either way worth formalizing one way or another I m too focused on another thing to remember exactly what the ideal semantics are but can look if helpful

witty-crayon-22786 · Answer

< hundreds father 404> there are about a dozen tests depending on it apparently

witty-crayon-22786 · Answer

without knowing it mostly

witty-crayon-22786 · Answer

see e g ```ValueError The address `src protobuf dir f proto` was not generated by the target `src protobuf dir dir` which only generated these addresses``` in <https github com pantsbuild pants runs 5118546407 check suite focus=true>

hundreds-father-404 · Answer

hmmm those tests look broken that s a valid error lmk if it d help for me to fix them to unblock you

witty-crayon-22786 · Answer

not with this accommodation i ve added it back so they pass

witty-crayon-22786 · Answer

oh this was also a thing for `python requirement` huh i think that that was the case where we last talked about this

hundreds-father-404 · Answer

how so

witty-crayon-22786 · Answer

when you explicitly declare a `python requirement` its name is `some explicit name` rather than `some explicit name` or w e

hundreds-father-404 · Answer

I think I m confused what a thing refers to here Are you saying we should apply the shortcut to `python requirement` for it to be ` ` rather than ` `

witty-crayon-22786 · Answer

eh re `python requirement` i might be mis remembering i found the thread though <https pantsbuild slack com archives C0D7TNJHL p1637020967476600>