Bikeshed We have the file `pants python binaries py` which d

Question

Bikeshed We have the file `pants python binaries py` which defines `PythonBinary` + `PythonBootstrapSubsystem`

hundreds-father-404 · Answer

I m moving `PythonBinary` to `core util rules system binaries` so now we re left with a dir w just that file and one class definition + accompanying logic Feels wrong Two thoughts on where to move this 1 `core subsystems python bootstrap py` That would be a new folder We could put things like anyonymous telemetry there which imo doesn t really belong in `pants goal` 2 `backend python util rules python boostrap py` That s a lie it s used by every backend

hundreds-father-404 · Answer

I m pretty sure `core subsystems` would be the right place but the thing holding me back is it s unlikely plugin authors would need to import `PythonBootstrapSubsystem` or `AnynomyousTelemetry` etc At least for `util rules ` it s meant to be useful things for plugin authors

hundreds-father-404 · Answer

cc < ancient vegetable 10556>

fast-nail-55400 · Answer

`core util rules python binaries py`

fast-nail-55400 · Answer

or singular

hundreds-father-404 · Answer

That feels even worse because this isn t really a util for plugin authors It truly is a subsystem that is needed for Pants s core

ancient-vegetable-10556 · Answer

Do we have a namespace for actual internals yet `internals subsystems python bootstrap py` would make sense to me

ancient-vegetable-10556 · Answer

and then we define `internals` as a package that is here be dragons for plugin authors

hundreds-father-404 · Answer

We don t Generally we ve been treating `core ` and `engine ` that way including `engine internals` This definitely doesn t belong in `engine internals` it s not foundational to Pants

ancient-vegetable-10556 · Answer

Right I guess I m wondering what expectations we ve been mis setting with `core` that is giving you cause for concern

hundreds-father-404 · Answer

gt that is giving you cause for concern I m pretty sure it s okay to put in `core subsystems` It s not wrong to import the type `PythonBootstrapSusbsystem` and in fact the Python backend needs to I do think `core util rules` is wrong tho as it s not really a util like `archive py` or `external tool py` is So my only hesitation is are we okay with adding a new folder to `core `

hundreds-father-404 · Answer

I ll make this new file name be a dedicated change so it can be properly bikeshedded documented in a PR

ancient-vegetable-10556 · Answer

Yes definitely

ancient-vegetable-10556 · Answer

having a ` subsystems` subpackage is an established pattern

ancient-vegetable-10556 · Answer

no reason not to do it

hundreds-father-404 · Answer