hundreds-father-404
02/24/2022, 8:41 PMpants/python/binaries.py
, which defines PythonBinary
+ PythonBootstrapSubsystem
.PythonBinary
to core/util_rules/system_binaries
, so now we're left with a dir w/ just that file and one class definition + accompanying logic. Feels wrong.
Two thoughts on where to move this:
1. core/subsystems/python_bootstrap.py
. That would be a new folder. We could put things like anyonymous telemetry there? which imo doesn't really belong in pants/goal
2. backend/python/util_rules/python_boostrap.py
. That's a lie, it's used by every backendcore/subsystems
would be the right place, but the thing holding me back is it's unlikely plugin authors would need to import PythonBootstrapSubsystem
or AnynomyousTelemetry
etc. At least for util_rules/
, it's meant to be useful things for plugin authorsfast-nail-55400
02/24/2022, 8:43 PMcore/util_rules/python_binaries.py
?hundreds-father-404
02/24/2022, 8:44 PMancient-vegetable-10556
02/24/2022, 8:45 PMinternals/subsystems/python_bootstrap.py
would make sense to meinternals
as a package that is here be dragons for plugin authorshundreds-father-404
02/24/2022, 8:46 PMcore/
and engine/
that way, including engine/internals
This definitely doesn't belong in `engine/internals`: it's not foundational to Pantsancient-vegetable-10556
02/24/2022, 8:47 PMcore
that is giving you cause for concern?hundreds-father-404
02/24/2022, 8:49 PMthat is giving you cause for concern?I'm pretty sure it's okay to put in
core/subsystems
. It's not wrong to import the type PythonBootstrapSusbsystem
, and in fact, the Python backend needs to.
I do think core/util_rules
is wrong tho, as it's not really a util like archive.py
or external_tool.py
is.
So, my only hesitation is "are we okay with adding a new folder to core/
?"ancient-vegetable-10556
02/24/2022, 9:00 PM/subsystems
subpackage is an established patternhundreds-father-404
02/25/2022, 1:34 AM