https://pantsbuild.org/ logo
Join Slack
Powered by
Is there a reason `GofmtSubsystem` doesn't have an...
# development
b
Is there a reason 
GofmtSubsystem
doesn't have an 
--args
option?
h
b
+1 on 
GoVetSubsystem
, 
GoogleJavaFormatSubsystem
, 
ScalafmtSubsystem
, 
TerraformValidateSubsystem
, and 
TfFmtSubsystem
h
I added "good first issue". We punted on it because the modeling wasn't immediately obvious and it was a lower priority
b
What about the others? 🤓
h
no idea on the others. cc @fast-nail-55400
f
because 
GoogleJavaFormatSubsystem
has a pretty small set of args and only its 
--aosp
option made sense to expose to the Pants user via the equivalent Pants option
👍 1
b
FWIW I'm looking at this from a consistency perspective. Was trying to look at our invocable tools wholistcally
f
terraform fmt
doesn’t have any options that change style
✅ 1
neither does 
terraform validate
go vet
could conceivably be configured with what checks to examine, but the Pants rules for it are bit rotten as I haven’t looked at it in a while.
scalafmt
does all config through its config file
🥴 2
the CLI options are for affecting which files to handle and for what mode to operate in
(and which config file to use …)
h
Let me guess that the scalafmt config file is a Scala DSL?
f
no actually. they are using HOCON syntax: https://scalameta.org/scalafmt/docs/configuration.html
h
Well that's refreshing
Open in Slack
PreviousNext
Powered by