https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

03/01/2022, 1:38 AM
Is there a reason
GofmtSubsystem
doesn't have an
--args
option?
h

hundreds-father-404

03/01/2022, 1:39 AM
b

bitter-ability-32190

03/01/2022, 1:39 AM
+1 on
GoVetSubsystem
,
GoogleJavaFormatSubsystem
,
ScalafmtSubsystem
,
TerraformValidateSubsystem
, and
TfFmtSubsystem
h

hundreds-father-404

03/01/2022, 1:39 AM
I added "good first issue". We punted on it because the modeling wasn't immediately obvious and it was a lower priority
b

bitter-ability-32190

03/01/2022, 1:43 AM
What about the others? 🤓
h

hundreds-father-404

03/01/2022, 1:43 AM
no idea on the others. cc @fast-nail-55400
f

fast-nail-55400

03/01/2022, 1:46 AM
because
GoogleJavaFormatSubsystem
has a pretty small set of args and only its
--aosp
option made sense to expose to the Pants user via the equivalent Pants option
👍 1
b

bitter-ability-32190

03/01/2022, 1:46 AM
FWIW I'm looking at this from a consistency perspective. Was trying to look at our invocable tools wholistcally
f

fast-nail-55400

03/01/2022, 1:46 AM
terraform fmt
doesn’t have any options that change style
1
neither does
terraform validate
go vet
could conceivably be configured with what checks to examine, but the Pants rules for it are bit rotten as I haven’t looked at it in a while.
scalafmt
does all config through its config file
🥴 2
the CLI options are for affecting which files to handle and for what mode to operate in
(and which config file to use …)
h

happy-kitchen-89482

03/01/2022, 1:56 AM
Let me guess that the scalafmt config file is a Scala DSL?
f

fast-nail-55400

03/01/2022, 1:57 AM
no actually. they are using HOCON syntax: https://scalameta.org/scalafmt/docs/configuration.html
h

happy-kitchen-89482

03/01/2022, 3:32 AM
Well that's refreshing