hundreds-father-404
03/09/2022, 7:11 PMavailable_concurrency
for building a PEX x lockfiles:--hash
• w/ Pex JSON lockfiles, we actually could parse the JSON and get an exact count. But John has discouraged that because the format is not stable
I'm wondering if for lockfiles, we switch to the imperfect no-lockfile heuristic of # of input requirements? Altho gr, even that doesn't work well, we only now the req_strings of the current context, which can be a subset. We'd need to parse the lockfile header to get the # of input requirements, but there's no guarantee a lockfile header is present due to manual lockfile generation
So maybe this?
1. Keep requirements.txt the same
2. Parse PEX JSON, but make this fail-safe if the format changes on us. Fall back to the req_strings
, even tho that's imperfectwitty-crayon-22786
03/09/2022, 7:12 PMAltho gr, even that doesn’t work well, we only now the req_strings of the current context, which can be a subset.consuming the lockfile for a subset should only actually build the subset, right? if so, that should be fine
enough-analyst-54434
03/09/2022, 7:29 PMwitty-crayon-22786
03/09/2022, 7:31 PMhundreds-father-404
03/09/2022, 7:38 PM--indent=2
when generating, which causes entries to have new lines. It will definitely overcountwitty-crayon-22786
03/09/2022, 7:38 PM