hundreds-father-404
03/10/2022, 9:47 PMhundreds-father-404
03/10/2022, 9:47 PM--hash
, meaning that VCS requirements can be supported. If you're using [python-repos]
, you already had to wire that up properly to your manual lockfile generation! Nothing new.
The only change from 2 and 4 is that Pants is stricter. Your lockfile must be comprehensive. Whereas with 2, Pex will fill in any unpinned transitive deps for you. And with 2, any missing direct deps will cause Pants to not use constraints.txt like a lockfile->repository.pex, instead behaving like approach 1) of no locks but with --constraints
set.
I'm proposing that we document 3) as the ideal, but heavily document you may run into issues like [python-repos]
and the transitive deps issue. As a result, many users will need to use approach 4)hundreds-father-404
03/10/2022, 9:47 PMhundreds-father-404
03/10/2022, 9:49 PMHard to tell without the content there. My gut instinct says if you present more than one way to something, be opinionated about when each is best applied. Otherwise it's just a new user hitting a stumbling block of trying to figure out whether to zig or zag.I agree it's confusing to describe when to use overall lock technology. Whereas now it's only how those lockfiles get generated
enough-analyst-54434
03/10/2022, 9:53 PMhundreds-father-404
03/10/2022, 9:55 PM[python-repos]
and VCS does not work, which has tripped up people
If it's hard to write about is that a sign to not do so?Iirc we've now had 3-4 users in the past 3 weeks who needed to use multiple lockfiles. I believe the majority of them used manual generation - not great, but better than status quo That suggests to me as incomplete as this feature is, it's better than the status quo and users want to know about.
enough-analyst-54434
03/10/2022, 9:56 PMwitty-crayon-22786
03/10/2022, 9:56 PMWhat if we stop documenting 2 in favor of always using 3 and 4?this sounds very reasonable, yea. migrating from 2 to 4 is still a step that heads in the right direction (toward 3, when that’s possible for ~everyone in
2.11.x
)hundreds-father-404
03/10/2022, 9:57 PMwhen that’s possible for ~everyone in 2.11.x)Possible for everyone but VCS users, most likely. So Pants 2.11 will still talk about approaches 3 and 4, but many more people can use 3 than they can now
witty-crayon-22786
03/10/2022, 9:58 PMhundreds-father-404
03/10/2022, 9:59 PMI think it would be good to do a postmortem on all this here in a few months.That'd be fruitful. Original sin is abusing constraints file way back in Pants 2.2 or whenever that was.
witty-crayon-22786
03/10/2022, 10:03 PMenough-analyst-54434
03/10/2022, 10:05 PMbitter-ability-32190
03/11/2022, 12:09 PMpex
command we talked about)hundreds-father-404
03/14/2022, 11:50 PMbusy-vase-39202
03/14/2022, 11:54 PMhappy-kitchen-89482
03/14/2022, 11:54 PMbusy-vase-39202
03/14/2022, 11:55 PMhundreds-father-404
03/14/2022, 11:55 PM