https://pantsbuild.org/ logo
Join Slack
Powered by
Is there a way to get processes to echo their stdo...
# development
a
Is there a way to get processes to echo their stdout/stderr automatically, or do we need to explicitly log their captured output? (@witty-crayon-22786)
w
the latter.
a
Oooft.
w
are you looking at the JVM output issue in 2.11.x?
a
Yeah. Trying to get that to happen systematically, without repeating the output for a single source file if it happens to be a repeated dependency
w
are you seeing the lack of output for all compiles, or only for some?
a
All compiles
w
a
there’s no code to output the errors at all
yes, it is
w
that code is supposed to raise the 
level
of the workunit for the compile to 
ERROR
, and then render the message
a
Well, it looks like the relevant rust code only prints the first line of the message
w
is there an ERROR line, but no message?
got it.
ok, sec.
(fwiw: it’s possible that bisecting would be worthwhile… but let me get you a pointer to the relevant codepath)
oh… actually. since it’s rendering the ERROR, that means that at least part of the EngineAwareReturnType mechanism is working.
can add a
Copy code
log::warn!("...")
in there to see whether it is being called at all, and then go from there
but since the level is actually being adjusted to ERROR, that implies that 
fn level
in the same file is actually taking affect.
a
let me poke around for just a moment
w
also: feel free to open an issue for this one and assign it to me… i suspect that it is related to my workunit changes, rather than something at a higher level
(particularly if 
30640b2225
is the change that introduced the issue)
a
So I get this (from 
JvmProcess -> FallibleProcessResult
)
Copy code
11:28:37.84 [INFO] Completed: Compile testprojects/src/jvm/org/pantsbuild/example/lib/ExampleLib.java with javac
And then there’s no subsequent logs related to the 
FallibleClasspathEntry
I’ll see if bisecting might help
w
you mentioned that there was an ERROR line?
but yea, i’m fairly sure that this is workunits. i can take a look
a
I think I may have been confused with the 
Completed
line,
Let me, at the very least, bisect to confirm for you
w
k. i would go so far as suggesting confirming before/after 
30640b2225
a
since I have a reproductioncase here
(words!)
@witty-crayon-22786 confirmed. 
javac
output present on 0aa7f290ed390ab3ceba0c44e4b38354d7a41d3d but not 30640b2225f7e8efd302ffa4d7f771b933570ca7
w
ok, thanks. i’ll tackle this one in a little bit.
a
I’ve added a commit that shows a minimal reproduction case that doesn’t get caught by javaparser etc (which do output issues)
Open in Slack
PreviousNext
Powered by