https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

03/28/2022, 12:40 AM
Should we deprecate
[python].run_against_entire_lockfile
if
enable_resolves
is
True
, and we detect it's a PEX lockfile (once we have the new "everything in a venv" solution)? There's very little reason to keep it around, the only one I can think of is backwards-compatibility (explained in ๐Ÿงต)
Re: backwards compat: I'm actually in this boat. Turns out my code doesn't lint or test without running against the entire lockfile. One reason is purely internal, the other being a complaint about missing
pkg_resources
(which I need to debug)
h

hundreds-father-404

03/28/2022, 2:44 PM
ohhh that's a good point on incremental adoption, I didn't think about that. My concern with that crutch is if people don't realize they should aim to get rid of it, so have a bad performance setting indefinitely --- maybe renaming the option could make that more clear
b

bitter-ability-32190

03/28/2022, 2:47 PM
Well deprecating it is pretty clear ๐Ÿ˜…
h

hundreds-father-404

03/28/2022, 2:57 PM
for sure, but maybe we do want to keep it to help people w/ incremental adoption. It lets you ignore issues w/ dependency inference of 3rd-party requirements along with undeclared transitive deps (like when
foo
doesn't properly say it needs
setuptools
for
pkg_resources
) Only nut sure the crutch is worth the risks
b

bitter-ability-32190

03/28/2022, 3:31 PM
Only nut sure the crutch is worth the risks
Or the Pants code bloat. I think the real focus should be on good documentation/tools to help devs navigate through these scenarios.
๐Ÿ‘ 1
โž• 1
Speaking of,
pex3 lock
isn't documented yet on https://pex.readthedocs.io/en/latest/
โค๏ธ 1
h

hundreds-father-404

03/28/2022, 6:00 PM
Speaking of, pex3 lock isn't documented yet on
https://github.com/pantsbuild/pex/issues/1653. I imagine John would appreciate help with it if you were interested
b

bitter-ability-32190

03/28/2022, 6:24 PM
There's like way too much detail in that feature for me to be able to capture it eloquently
๐Ÿ‘ 1