https://pantsbuild.org/ logo
#development
Title
# development
h

hundreds-father-404

03/30/2022, 12:27 AM
can a releaser please do the pants.pex release for 2.9.1 for me? (As mentioned before, I have issues w/ my M1)
👍 1
h

happy-kitchen-89482

03/30/2022, 1:58 AM
That pex doesn't even work:
Copy code
$ ./dist/deploy/pex/pants.2.9.1.pex  
18:57:51.94 [INFO] Initializing scheduler...
18:57:53.12 [ERROR] no path specified
Traceback (most recent call last):
  File "/Users/benjyw/.pex/venvs/s/ee12e562/venv/lib/python3.7/site-packages/pants/bin/daemon_pants_runner.py", line 124, in single_daemonized_run
    scheduler, options_initializer = self._core.prepare(options_bootstrapper, complete_env)
  File "/Users/benjyw/.pex/venvs/s/ee12e562/venv/lib/python3.7/site-packages/pants/pantsd/pants_daemon_core.py", line 175, in prepare
    scheduler_restart_explanation,
  File "/Users/benjyw/.pex/venvs/s/ee12e562/venv/lib/python3.7/site-packages/pants/pantsd/pants_daemon_core.py", line 118, in _initialize
    raise e
  File "/Users/benjyw/.pex/venvs/s/ee12e562/venv/lib/python3.7/site-packages/pants/pantsd/pants_daemon_core.py", line 112, in _initialize
    self._services = self._services_constructor(bootstrap_options, self._scheduler)
  File "/Users/benjyw/.pex/venvs/s/ee12e562/venv/lib/python3.7/site-packages/pants/pantsd/pants_daemon.py", line 85, in _setup_services
    bootstrap_options,
  File "/Users/benjyw/.pex/venvs/s/ee12e562/venv/lib/python3.7/site-packages/pants/option/global_options.py", line 1604, in compute_pantsd_invalidation_globs
    glob_relpath = os.path.relpath(glob, buildroot)
  File "/Users/benjyw/.pyenv/versions/3.7.3/lib/python3.7/posixpath.py", line 457, in relpath
    raise ValueError("no path specified")
ValueError: no path specified
Why do we release them? Do we have evidence that anyone uses them?
Anyway, I've done the pex release for 2.9.1, but it's unclear to me that we should still be doing these... :)
I'm not sure they work
w

witty-crayon-22786

03/30/2022, 4:22 AM
that is a bug that was fixed in 2.10.x, but apparently not in 2.9.x: https://github.com/pantsbuild/pants/pull/14819
👀 1
h

hundreds-father-404

03/30/2022, 1:44 PM
we have one user known to be using them for security reasons. but they aren't dogfooded very well, e.g. they reported https://github.com/pantsbuild/pants/issues/14938
w

witty-crayon-22786

03/30/2022, 10:23 PM
i think that an important part of https://github.com/pantsbuild/pants/issues/12397 will be making the PEX distribution model the one-and-only model, to remove the split focus. until then, it’s going to be a secondary concern.
👍 1
h

hundreds-father-404

03/30/2022, 10:25 PM
im trying to fix the pex version thing now, i reproduce we're using git in it which is wrong
w

witty-crayon-22786

03/30/2022, 10:26 PM
the “reversioning” of wheels that we do is supposed to be the thing that rewrites from git-versioned to stable… it’s possible that the pex building is not using the reversioned wheels
1
h

hundreds-father-404

03/30/2022, 10:42 PM
should we delete pants.pex for 2.9 given that it doesnt work? we did 2.9.1 and i doubt will do 2.9.2 now that 2.10 is stable?
w

witty-crayon-22786

03/30/2022, 10:43 PM
yes, probably. if users come asking for it, we’ll know that we need to revisit. but better than having it be broken.
👍 1
h

hundreds-father-404

03/30/2022, 10:44 PM
will do. broke in 9.dev4
w

witty-crayon-22786

03/30/2022, 10:45 PM
and lets go ahead and cherry-pick both of these fixes, just in case we do another release there.
👍 1