witty-crayon-2278604/21/2022, 4:05 AM
option type which took either a target address string, or … literal BUILD file content which defined a target to use.
default = 'python_requirement(requirements=["mypy==0.782"])'
default = 'jdk(id="adoptjdk:1.11", max_memory="12G")'
happy-kitchen-8948204/21/2022, 5:34 AM
hundreds-father-40404/21/2022, 12:19 PM
bitter-ability-3219004/21/2022, 12:22 PM
witty-crayon-2278604/21/2022, 4:34 PM
What’s the benefit of inlining? You could define it externally and reference it, right?the primary benefit is the default values of “toolchain like” settings like the JDK, the resolve, etc… complex objects. you want a default to reduce the boilerplate involved in setting up a brand new repository
hundreds-father-40404/21/2022, 4:47 PM
witty-crayon-2278604/21/2022, 4:48 PM
fast-nail-5540004/21/2022, 5:39 PM
witty-crayon-2278604/21/2022, 5:44 PM
What is the benefit of this approach versus other approaches such as engine-provided targets (with engine-scoped addresses for them)?it is just a concrete design for that feature, basically. a benefit to this design is that it has useful help right out of the box.
Or proper toolchain selection support.i’m not sure what that means: afaict, a toolchain is a collection of settings, the same as a target. and having it be configured as a target option allows for toggling it based on context.