I'm making some wording improvements to `[python-i...
# developmenth
hundreds-father-404
05/04/2022, 11:05 PMI'm making some wording improvements to
[python-infer].unowned_dependency_behaviorwarnw
witty-crayon-22786
05/04/2022, 11:09 PMambiguity is definitely noisy… have thought that we might want to move ambiguity warnings to mapping computation time, rather than symbol/package lookup time. then you could dedupe, and group by file providing a symbol.
unowned_dependency_behavior👍 1
💯 1
witty-crayon-22786
05/04/2022, 11:09 PM(although i suppose it depends on the repo you’re enabling in.)
h
hundreds-father-404
05/04/2022, 11:10 PMunowned_dependency_behavior should be much less verbose though, right?I feel in my gut pretty strongly that we will want to error rather than warn, although still trying to build the argument for why I believe this If we default to error, I'm less worried as the error is one file at a time (but batches all imports in the file)
hundreds-father-404
05/04/2022, 11:13 PMambiguity is definitely noisy… have thought that we might want to move ambiguity warnings to mapping computation time, rather than symbol/package lookup time. then you could dedupe, and group by file providing a symbol.I like it. I also think we might want to offer an option to error, and possibly even default to it FYI the reason we before had to wait until import-time is pre-multiple lockfiles, it was valid to have multiple 3rd-party conflicting deps and callers would choose. Now they should choose via resolve Wait but still not sure we can do it actually. It's valid to have 5 targets for a test, all w/ the same resolve
w
witty-crayon-22786
05/04/2022, 11:13 PMi don’t know of a good way to actually show a user all errors and still error. you’d need batching, or some scope in which they were all collected before failing
witty-crayon-22786
05/04/2022, 11:13 PM(…or make it fallible, similar to JVM/go compilation)
witty-crayon-22786
05/04/2022, 11:16 PMWait but still not sure we can do it actually. It’s valid to have 5 targets for a test, all w/ the same resolvetrue… would need some element of laziness still, to not actually render for the first time unless you consumed it.
👍 1