https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

05/06/2022, 6:17 PM
@happy-kitchen-89482: so, one way to more holistically address https://github.com/pantsbuild/pants/issues/15336 might be to merge
--build-patterns
and
--build-ignore
into
--build-globs
, using exactly the same (non-recursive by default) syntax as globs in general. i.e., it would default to
['**/BUILD', **/BUILD.*']
, and you could include inline negation there. that would mean one codepath, and one explanation of globs.
it wouldn’t affect the ability to negate out something that had already been excluded though.
… so. maybe unrelated.
h

hundreds-father-404

05/06/2022, 6:18 PM
seems like a good simplification in general
with us already having an option for tailor's build file name, that brings us to 3 total related to build file names
nit that I recommend
build_file_globs
over
build_globs
👍 2
w

witty-crayon-22786

05/06/2022, 6:20 PM
yea. just not sure of the priority i suppose. it unifies the explanation, but it also feels deck-chair-shuffley
i’ll get a patch out for the help cleanup, and if there is appetite for a merge we can land that instead.
h

hundreds-father-404

05/06/2022, 6:24 PM
but it also feels deck-chair-shuffley
For sure, but maybe worth it given how many future releases we'll have. Imo this relates to onboarding: you set this up during onboarding process, usually. Even little wins like 2 coupled options -> 1 matter. Shorter docs etc
h

happy-kitchen-89482

05/06/2022, 6:51 PM
low priority, but a good idea, yes
and I think not supporting functionality that gitignore itself doesn't is fine
w

witty-crayon-22786

05/06/2022, 7:17 PM
(…we’ll want to cherry-pick this, even if we do merge those options.)