https://pantsbuild.org/ logo
Join Slack
Powered by
Wasn't expecting to see intrisic rules being compl...
# development
b
Wasn't expecting to see intrisic rules being complained about in my test 😕
Copy code
No installed rules return the type AddPrefix, and it was not provided by potential callers of @rule(<intrinsic>(AddPrefix) -> Digest).
✅ 1
f
It’s probably not from the intrinsic. The missing rule errors are not good.
b
Full stack trace only shows intrinsics:
Copy code
E       ValueError: Encountered 7 rule graph errors:
E         No installed rules return the type AddPrefix, and it was not provided by potential callers of @rule(<intrinsic>(AddPrefix) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No installed rules return the type CreateDigest, and it was not provided by potential callers of @rule(<intrinsic>(CreateDigest) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No installed rules return the type DigestSubset, and it was not provided by potential callers of @rule(<intrinsic>(DigestSubset) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No installed rules return the type DownloadFile, and it was not provided by potential callers of @rule(<intrinsic>(DownloadFile) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No installed rules return the type MergeDigests, and it was not provided by potential callers of @rule(<intrinsic>(MergeDigests) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No installed rules return the type PathGlobs, and it was not provided by potential callers of @rule(<intrinsic>(PathGlobs) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No installed rules return the type RemovePrefix, and it was not provided by potential callers of @rule(<intrinsic>(RemovePrefix) -> Digest).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
f
can you share the plugin code?
or did it work in an earlier iteration and then share the diff?
b
Will post PR, one sec
(also about to go to bed, no rush)
👍 1
Specifically, the last test: 
test_invalid_asset_fields
f
as an aside: the use of not inheriting from 
Target
for a target is suspicious
b
The targets are inheriting from 
Target
?
f
inheriting directly I mean
versus using a FieldSet (which could derive from a Union as well if you wanted to support)
b
I don't follow, but feel free to comment on PR
Oddly in other tests, they add the 
QueryRule
provided by the intrinsic. 
src/python/pants/backend/codegen/protobuf/go/rules_integration_test.py
and 
src/python/pants/core/goals/export_test.py
both do this
f
will take a look over the weekend
nothing stood out at first glance
b
removing the target type rules works 🤷‍♂️
f
weird
b
very
f
although random code mutations is the same way that I also figure out engine rule graph errors 😞
b
I'll call it ✅ so we don't waste more time on it, but FYI @witty-crayon-22786 if you want a puzzle 😛
w
Mmm, will look Monday.
b
Again, only if you wanna. No one is blocked.
Open in Slack
PreviousNext
Powered by