hundreds-father-404
05/19/2022, 12:36 AMlist
, test
) and target-less goals (tailor
, count-loc
).
But a big dilemma is FilesystemIgnoreSpec
, e.g. !foo.py
and !*.py
. 🧵hundreds-father-404
05/19/2022, 12:36 AM./pants test project/tests.py:tgt '!project/tests.py'
should result in no targets matched. But it doesn't! The ignore spec does nothing.
In the design doc, I propose that we should have ignore options for every spec type, so you can do dir:: '!dir/but_not_me::'
. That is consistent and powerful
I think we need to do that as a holistic project for "ignore specs" tho. The status quo is brokenhundreds-father-404
05/19/2022, 12:38 AMFilesystemIgnoreSpec
is making this project really hard for me to reason about and implement
So, I'm proposing that we simply remove the feature...it's incomplete and I expect not widely used. We never document it anywherehundreds-father-404
05/19/2022, 12:38 AMhundreds-father-404
05/19/2022, 12:38 AMhundreds-father-404
05/19/2022, 12:39 AMFileLiteralSpec
or FileGlobSpec
, the FileIgnoreSpec
will filter out the file beforehand. It has no impact on AddressSpecs
, which I think it shouldbitter-ability-32190
05/19/2022, 12:42 AMbitter-ability-32190
05/19/2022, 12:42 AMhundreds-father-404
05/19/2022, 12:43 AMdir::
to recurse
Regardless of the goal. For each of those, you can use !
in front to negate
We can have a tool tip w/ more advanced specs...
• 'dir/*.ext'
(requires quotes)
• dir^
= dir + ancestors
• dir:
, which has less intuitive semantics than dirhundreds-father-404
05/19/2022, 1:21 AM