still working on minimizing it to file a bug report, but wanted to flag it early: we just hit a bug / behavior change with tag-based filtering when upgrading to

v2.11.1rc0

. We have a CI step that essentially does

./pants --changed-dependees=transitive --changed-since=$(git rev-parse HEAD~) --tag=push_to_ecr filter --target-type=docker_image

. After upgrading to

v2.11.1rc0

, the filter fails to notice images with the tag - removing the

--tag

arg fixes things. We upgraded from commit

9ac327d46d8ef98a6f635c9795e26433b50e62b8

(on the 2.11.x branch) so one of the commits between it and the RC changed the behavior

hmm, thank you for the report - definitely appreciated if you're able to minimize more. 2.11.1rc0 indeed has what is supposed to be several fixes to

--tags

the other probably-relevant thing to note is that the change we expected to be detected was in a transitive dependency without the tag. I could see a change to filter’s order-of-operations breaking that (i.e. filtering out everything w/o the tag up-front, then checking transitive deps that have changed, but now there are no transitive deps left because none of them had the tag)

this was the change: https://github.com/pantsbuild/pants/pull/15394

the setup is effectively:

app/
  Dockerfile
  entrypoint.sh
  BUILD.pants

and then in `BUILD.pants`:

shell_source(name="entrypoint", source="entrypoint.sh")

docker_image(tags=["push_to_ecr"], dependencies=[":entrypoint"])

we made a change to

entrypoint.sh

, then ran an equivalent of:

./pants --changed-dependees=transitive --changed-since=$(git rev-parse HEAD~) --tag=push_to_ecr filter --target-type=docker_image

pre-2.11.1rc0 this would print the target for

app/Dockerfile

. on 2.11.1rc0 the target for

app/Dockerfile

is not printed

Thanks for reporting, and the work on narrowing it down!

Got it. So this was in theory intentional...The idea is when you use

--tag

, you will only get back things w/ the tag. I'm trying to think about what is desirable though.

--changed-dependees

is a wild-card here I didn't consider enough. In the meantime, I think we should revert the changes to 2.11, as it looks like it's breaking and violates the stability we try to offer

so speedy! thank you 🎉