I m trying to align `tailor` to the new consistent CLI args

Question

I m trying to align `tailor` to the new consistent CLI args semantics Most cases are obvious `tailor ` gt everything `tailor dir ` gt everything in `dir` and below `tailor dir` gt everything in `dir` The super tricky thing is how to handle a single file ` pants tailor src py tests py` Do we think it s important that only adds a `python tests` target and not `python sources` if the dir was missing it Or is it fine if it gets expanded to the whole directory

hundreds-father-404 · Answer

gt The super tricky thing is how to handle a single file pants tailor src py tests py Do we think it s important that only adds a python tests target and not python sources if the dir was missing it This is challenging to pull off For example what if you say to only run on `foo test py` and it turns out `bar test py` is also missing a `python tests` target Do we set `sources= foo test py ` rather than using the default sources I think I could probably figure it out but it is hard and will will likely require rewriting `tailor` implementations

fast-nail-55400 · Answer

Maybe just tell the user that it is ambiguous what to do in that instance

hundreds-father-404 · Answer

Thank you for the idea I was about to say awesome perfect Until I realized that means ` pants changed since=HEAD tailor` will error as it uses `FileLiteralSpec` to work

hundreds-father-404 · Answer

gt pants changed since=HEAD tailor Using this as a case study You create a new directory for now w just one test file I think most users would rather have `python tests ` than `python tests sources= my test py ` It s more future proof Which suggests to me we should replace a file literal w its directory

high-energy-55500 · Answer

should `tailor` work with single files at all if `BUILD` files exist at the directory level I don t think it makes sense to run `tailor` against files only directories

hundreds-father-404 · Answer

The only reason I say yes to single files is that ` pants changed since=HEAD tailor` should work and that requires individual files to work But I ended up implementing this as a single file gt run against that file s whole directory I m pretty sure it s what makes sense and 100x easier to implement

high-energy-55500 · Answer

yeah that makes sense and it s most likely what a user would mean if they asked to run tailor on a file