I'm translating the following mapping (names are arbitrary):

@dataclass(frozen=True)
class Bikeshed:
    input_digest: Digest
    immutable_input_digests: FrozenDict[str, Digest]
    use_nailgun: tuple[str, ...]
    output_files: tuple[str, ...]
    output_directories: tuple[str, ...]


@dataclass(frozen=True)
class CoalescedProcessBatch:
    files_to_bikesheds = FrozenDict[str, Bikeshed]

to the rust equivalent:

#[derive(DeepSizeOf, Derivative, Clone, Debug, Eq, Serialize)]
#[derivative(PartialEq, Hash)]
pub struct Bikeshed {
  pub input_digests: InputDigests,
  pub output_files: BTreeSet<RelativePath>,
  pub output_directories: BTreeSet<RelativePath>,
}

#[derive(DeepSizeOf, Derivative, Clone, Debug, Eq, Serialize)]
#[derivative(PartialEq, Hash)]
pub struct CoalescedProcessBatch {
  pub files_to_bikesheds: BTreeMap<RelativePath, Bikeshed>,

The stumbling block here is that to turn

input_digest: Digest
    immutable_input_digests: FrozenDict[str, Digest]
    use_nailgun: tuple[str, ...]

into a Rust

InputDigests

involves async store code, which

Python::with_gil

doesn't allow

The process lifting accomplishes this by having

Python::with_gil

return a future which we then

await

. I'm attempting the same, but stumbling very Hard. Namely because I'm doing this on N, instead of one (so trying to have a vector of futures and

try_join_all

them)

but you should be able to follow the same pattern of “return a

Vec<somesuch Future>

, then

try_join_all

it outside of the gil”

I feel like I'm sprinkling

Ok(...)

s everywhere. I get the feeling if you're hammering out `Ok`s, everything IS NOT

Ok

😂

but generally what you want to do there is:

collect an iter of

Result<T, E>

into a

Result<Vec<T>, E>

:

.collect::<Result<Vec<_>, _>>()

is usually sufficient

blargh, slack kept eating my angle brackets… fixed now i think.

Well I think we got past that issue with the

collect()

code you posted

Oh no... my code compiles

(unless you’ve got a deadlock… still can’t catch those, heh)

PR has the code. Please take an anti-nausea pill prior to viewing: https://github.com/pantsbuild/pants/pull/15648